Bug 1266340 - Explicitly close menu when finishing action mode. r=capella
authorSebastian Kaspari <s.kaspari@gmail.com>
Thu, 21 Apr 2016 14:28:58 +0200
changeset 331975 766c8d6d4198c7612a457137b8fc5944a63e1270
parent 331974 adc7dd34508b4133a986bee775b6a75552e13ecb
child 331976 2ca0a1672d8ff4500d37bbb7d753fc03b729cabf
push id6048
push userkmoir@mozilla.com
push dateMon, 06 Jun 2016 19:02:08 +0000
treeherdermozilla-beta@46d72a56c57d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscapella
bugs1266340
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1266340 - Explicitly close menu when finishing action mode. r=capella MozReview-Commit-ID: LZiufFsemS1
mobile/android/base/java/org/mozilla/gecko/ActionModeCompat.java
--- a/mobile/android/base/java/org/mozilla/gecko/ActionModeCompat.java
+++ b/mobile/android/base/java/org/mozilla/gecko/ActionModeCompat.java
@@ -55,17 +55,20 @@ class ActionModeCompat implements GeckoP
         mCallback = callback;
 
         mView = view;
         mView.initForMode(this);
     }
 
     public void finish() {
         // Clearing the menu will also clear the ActionItemBar
-        mView.getMenu().clear();
+        final GeckoMenu menu = mView.getMenu();
+        menu.clear();
+        menu.close();
+
         if (mCallback != null) {
             mCallback.onDestroyActionMode(this);
         }
     }
 
     public CharSequence getTitle() {
         return mView.getTitle();
     }