Bug 1366426 - autocomplete-richlistbox height does not fit results anymore. r=adw
authorMarco Bonardo <mbonardo@mozilla.com>
Thu, 25 May 2017 18:35:35 +0200
changeset 409049 75f640c290e2a8f6247cd699f5bac56fc5901e2b
parent 409048 f08aa17062e88cd6d347ea1b5d8740a755df2b61
child 409050 9494a5b0b185cc35bcdd6cd822c60e1c609d5d50
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersadw
bugs1366426
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1366426 - autocomplete-richlistbox height does not fit results anymore. r=adw MozReview-Commit-ID: DiJO4DZI49O
browser/base/content/browser.css
browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-in.js
browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js
--- a/browser/base/content/browser.css
+++ b/browser/base/content/browser.css
@@ -606,22 +606,22 @@ html|input.urlbar-input[textoverflow]:no
   -moz-binding: url("chrome://browser/content/urlbarBindings.xml#urlbar-rich-result-popup");
 }
 
 #PopupAutoCompleteRichResult.showSearchSuggestionsNotification {
   transition: height 100ms;
 }
 
 #PopupAutoCompleteRichResult > deck[anonid="search-suggestions-notification"] {
-  visibility: collapse;
+  display: none;
   transition: margin-top 100ms;
 }
 
 #PopupAutoCompleteRichResult.showSearchSuggestionsNotification > deck[anonid="search-suggestions-notification"] {
-  visibility: visible;
+  display: -moz-deck;
 }
 
 #PopupAutoCompleteRichResult > richlistbox {
   transition: height 100ms;
 }
 
 #PopupAutoCompleteRichResult.showSearchSuggestionsNotification > richlistbox {
   transition: none;
--- a/browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-in.js
+++ b/browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-in.js
@@ -212,17 +212,18 @@ function suggestionsPresent() {
     }
   }
   return false;
 }
 
 function assertVisible(visible, win = window) {
   let style =
     win.getComputedStyle(win.gURLBar.popup.searchSuggestionsNotification);
-  Assert.equal(style.visibility, visible ? "visible" : "collapse");
+  let check = visible ? "notEqual" : "equal";
+  Assert[check](style.display, "none");
 }
 
 function promiseTransition(win = window) {
   return new Promise(resolve => {
     win.gURLBar.popup.addEventListener("transitionend", function() {
       // The urlbar needs to handle the transitionend first, but that happens
       // naturally since promises are resolved at the end of the current tick.
       resolve();
--- a/browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js
+++ b/browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js
@@ -117,14 +117,15 @@ function suggestionsPresent() {
     }
   }
   return false;
 }
 
 function assertVisible(visible, win = window) {
   let style =
     win.getComputedStyle(win.gURLBar.popup.searchSuggestionsNotification);
-  Assert.equal(style.visibility, visible ? "visible" : "collapse");
+  let check = visible ? "notEqual" : "equal";
+  Assert[check](style.display, "none");
 }
 function assertFooterVisible(visible, win = window) {
   let style = win.getComputedStyle(win.gURLBar.popup.footer);
   Assert.equal(style.visibility, visible ? "visible" : "collapse");
 }