Backed out changeset 5decd51af7a9 (bug 1369282) for breaking the build by trying to ship a duplicated file
authorPhil Ringnalda <philringnalda@gmail.com>
Wed, 07 Jun 2017 21:02:34 -0700
changeset 411021 757a3c336d6e5e399fa944b4342372f233bb72c3
parent 411020 69f302e5caf1584341425d0eac6e4144dc3a3396
child 411022 66124e23e8d8637de199d3ede303ec3cb9672f55
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1369282
milestone55.0a1
backs out5decd51af7a980c2b96c95bb9729610dabeb9d9d
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 5decd51af7a9 (bug 1369282) for breaking the build by trying to ship a duplicated file CLOSED TREE MozReview-Commit-ID: wmARe5Aata
browser/extensions/onboarding/README.md
browser/extensions/onboarding/content/img/onboarding-close-icon.svg
browser/extensions/onboarding/content/onboarding.css
browser/extensions/onboarding/content/onboarding.js
deleted file mode 100644
--- a/browser/extensions/onboarding/README.md
+++ /dev/null
@@ -1,20 +0,0 @@
-# Onboarding
-
-System addon to provide the onboarding overlay for user friendly tours.
-
-## Architecture
-
-Everytime `about:home` or `about:newtab` page is opened, onboarding overlay is injected into that page (if `browser.onboarding.enabled` preference is `true`).
-
-## Landing rules
-
-We would apply some rules:
-
-* Avoid `chrome://` in `onbaording.js` since onboarding is intented to be injected into a normal content process page.
-* All styles and ids should be formated as `onboarding-*` to avoid conflict with the origin page.
-* All strings in `locales` should be formated as `onboarding.*` for consistency.
-
-## References
-
-Content process related change:
-* The `overlay-close.svg` comes from `browser/themes/shared/sidebar/close.svg`.
deleted file mode 100644
--- a/browser/extensions/onboarding/content/img/onboarding-close-icon.svg
+++ /dev/null
@@ -1,6 +0,0 @@
-<!-- This Source Code Form is subject to the terms of the Mozilla Public
-   - License, v. 2.0. If a copy of the MPL was not distributed with this
-   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
-<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16">
-  <path fill="context-fill" d="M9.061,8l3.47-3.47A.75.75,0,0,0,11.47,3.47L8,6.939,4.53,3.47A.75.75,0,0,0,3.47,4.53L6.939,8,3.47,11.47A.75.75,0,1,0,4.53,12.53L8,9.061l3.47,3.47A.75.75,0,0,0,12.53,11.47Z"/>
-</svg>
--- a/browser/extensions/onboarding/content/onboarding.css
+++ b/browser/extensions/onboarding/content/onboarding.css
@@ -32,31 +32,20 @@
   offset-inline-start: 30px;
   background: url("img/overlay-icon.svg") no-repeat;
 }
 
 #onboarding-overlay-dialog {
   display: none;
 }
 
-#onboarding-overlay-close-btn {
+#onboarding-tour-close-btn {
   position: absolute;
   top: 15px;
   offset-inline-end: 15px;
-  cursor: pointer;
-  width: 16px;
-  height: 16px;
-  background-image: url(img/onboarding-close-icon.svg);
-  background-position: center center;
-  background-repeat: no-repeat;
-  padding: 12px;
-}
-
-#onboarding-overlay-close-btn:hover {
-  background-color: rgba(204, 204, 204, 0.6);
 }
 
 #onboarding-overlay.opened > #onboarding-overlay-dialog {
   width: 1200px;
   height: 550px;
   background: #f5f5f7;
   border: 1px solid rgba(9, 6, 13, 0.1); /* #09060D, 0.1 opacity */
   position: relative;
--- a/browser/extensions/onboarding/content/onboarding.js
+++ b/browser/extensions/onboarding/content/onboarding.js
@@ -37,17 +37,17 @@ class Onboarding {
     // Destroy on unload. This is to ensure we remove all the stuff we left.
     // No any leak out there.
     this._window.addEventListener("unload", () => this.destroy());
   }
 
   handleEvent(evt) {
     switch (evt.target.id) {
       case "onboarding-overlay-icon":
-      case "onboarding-overlay-close-btn":
+      case "onboarding-tour-close-btn":
       // If the clicking target is directly on the outer-most overlay,
       // that means clicking outside the tour content area.
       // Let's toggle the overlay.
       case "onboarding-overlay":
         this.toggleOverlay();
         break;
     }
   }
@@ -64,17 +64,17 @@ class Onboarding {
   _renderOverlay() {
     let div = this._window.document.createElement("div");
     div.id = "onboarding-overlay";
     // Here we use `innerHTML` is for more friendly reading.
     // The security should be fine because this is not from an external input.
     // We're not shipping yet so l10n strings is going to be closed for now.
     div.innerHTML = `
       <div id="onboarding-overlay-dialog">
-        <span id="onboarding-overlay-close-btn"></span>
+        <button id="onboarding-tour-close-btn">X</button>
         <header>Getting started?</header>
         <nav>
           <ul></ul>
         </nav>
         <footer>
         </footer>
       </div>
     `;