Bug 1116578 - Make customize mode keyboard accessible by allowing tabbing through the toolbarpaletteitems and using the context menu key or keyboard shortcut (Shift+F10 on Windows and Linux) to open the context menu and move items between customizable areas. r=Gijs
authorJared Wein <jwein@mozilla.com>
Fri, 22 Apr 2016 10:35:00 -0400
changeset 332399 752d9eb3ebea2993d4fb32b3513db9f9b6b766e3
parent 332398 c21153b1155fa7f162245fb546cfaef75f2bc8ec
child 332400 fe65164421a0ddbb73e6d49ddc456be9440af420
push id6048
push userkmoir@mozilla.com
push dateMon, 06 Jun 2016 19:02:08 +0000
treeherdermozilla-beta@46d72a56c57d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1116578
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1116578 - Make customize mode keyboard accessible by allowing tabbing through the toolbarpaletteitems and using the context menu key or keyboard shortcut (Shift+F10 on Windows and Linux) to open the context menu and move items between customizable areas. r=Gijs MozReview-Commit-ID: 2Vjfh9AwpQ7
browser/base/content/browser.css
browser/themes/shared/customizableui/customizeMode.inc.css
--- a/browser/base/content/browser.css
+++ b/browser/base/content/browser.css
@@ -333,16 +333,24 @@ toolbarpaletteitem > toolbaritem[sdkstyl
   display: -moz-box;
 }
 
 toolbarpaletteitem[removable="false"] {
   opacity: 0.5;
   cursor: default;
 }
 
+%ifndef XP_MACOSX
+toolbarpaletteitem[place="palette"],
+toolbarpaletteitem[place="panel"],
+toolbarpaletteitem[place="toolbar"] {
+  -moz-user-focus: normal;
+}
+%endif
+
 #bookmarks-toolbar-placeholder,
 toolbarpaletteitem > #personal-bookmarks > #PlacesToolbar,
 #personal-bookmarks[cui-areatype="menu-panel"] > #PlacesToolbar,
 #personal-bookmarks[cui-areatype="toolbar"][overflowedItem=true] > #PlacesToolbar {
   display: none;
 }
 
 #PlacesToolbarDropIndicatorHolder {
--- a/browser/themes/shared/customizableui/customizeMode.inc.css
+++ b/browser/themes/shared/customizableui/customizeMode.inc.css
@@ -256,16 +256,24 @@ toolbarpaletteitem[place="toolbar"] {
   margin-right: 0;
   margin-left: 0;
 }
 
 #customization-palette:not([hidden]) {
   margin-bottom: 25px;
 }
 
+toolbarpaletteitem[place="palette"]:-moz-focusring,
+toolbarpaletteitem[place="panel"]:-moz-focusring,
+toolbarpaletteitem[place="toolbar"]:-moz-focusring {
+  outline: 1px dotted rgba(0,0,0,.5);
+  outline-offset: -5px;
+  -moz-outline-radius: 2.5px;
+}
+
 #wrapper-edit-controls[place="palette"] > #edit-controls > toolbarbutton,
 #wrapper-edit-controls[place="palette"] > #edit-controls > separator,
 #wrapper-zoom-controls[place="palette"] > #zoom-controls > toolbarbutton,
 #wrapper-zoom-controls[place="palette"] > #zoom-controls > separator {
   margin-top: 20px;
 }
 
 #wrapper-edit-controls[place="palette"] > #edit-controls > toolbarbutton,