Bug 820653 - use listStyleImage for social provider toolbar image to ensure correct image size. r=jaws
authorMark Hammond <mhammond@skippinet.com.au>
Thu, 20 Dec 2012 10:50:23 +1100
changeset 125689 73f36736a1aeb82d61be4b66088ddfe0f5a99796
parent 125688 ae4a7e6f0e0b11bd4a3072366b3d200d3bef1520
child 125690 8793edbf2a322be6a7a6b50bf4549cc3def11007
push id2151
push userlsblakk@mozilla.com
push dateTue, 19 Feb 2013 18:06:57 +0000
treeherdermozilla-beta@4952e88741ec [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs820653
milestone20.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 820653 - use listStyleImage for social provider toolbar image to ensure correct image size. r=jaws
browser/base/content/browser-social.js
browser/themes/gnomestripe/browser.css
browser/themes/pinstripe/browser.css
browser/themes/winstripe/browser.css
--- a/browser/base/content/browser-social.js
+++ b/browser/base/content/browser-social.js
@@ -713,17 +713,17 @@ var SocialToolbar = {
     this.updateProvider();
     this._dynamicResizer = new DynamicResizeWatcher();
   },
 
   // Called when the Social.provider changes
   updateProvider: function () {
     if (!Social.provider)
       return;
-    this.button.setAttribute("image", Social.provider.iconURL);
+    this.button.style.listStyleImage = "url(" + Social.provider.iconURL + ")";
     this.updateButton();
     this.updateProfile();
     this.populateProviderMenus();
   },
 
   get button() {
     return document.getElementById("social-provider-button");
   },
--- a/browser/themes/gnomestripe/browser.css
+++ b/browser/themes/gnomestripe/browser.css
@@ -2346,16 +2346,20 @@ html|*#gcli-output-frame {
 .social-notification-icon-hbox {
   pointer-events: none;
 }
 
 .social-status-button {
   list-style-image: none;
 }
 
+#social-provider-button {
+  -moz-image-region: rect(0, 16px, 16px, 0);
+}
+
 #social-provider-button > image {
   margin: 5px 3px;
 }
 
 #social-provider-button > .toolbarbutton-menu-dropmarker {
   display: none;
 }
 
--- a/browser/themes/pinstripe/browser.css
+++ b/browser/themes/pinstripe/browser.css
@@ -3812,16 +3812,20 @@ html|*#gcli-output-frame {
 .social-notification-icon-hbox {
   pointer-events: none;
 }
 
 .social-status-button {
   list-style-image: none;
 }
 
+#social-provider-button {
+  -moz-image-region: rect(0, 16px, 16px, 0);
+}
+
 #social-provider-button > .toolbarbutton-menu-dropmarker {
   display: none;
 }
 
 .social-notification-icon-stack {
   padding: 0;
 }
 
--- a/browser/themes/winstripe/browser.css
+++ b/browser/themes/winstripe/browser.css
@@ -3013,16 +3013,19 @@ html|*#gcli-output-frame {
   min-width: 16px;
   text-shadow: none;
   background-image: -moz-linear-gradient(top, #B4211B, #8A1915);
   border-radius: 1px;
   -moz-margin-end: 5px;
 }
 
 /* Social toolbar item */
+#social-provider-button {
+  -moz-image-region: rect(0, 16px, 16px, 0);
+}
 
 #social-provider-button > .toolbarbutton-menu-dropmarker {
   display: none;
 }
 
 #social-toolbar-item > .toolbarbutton-1 {
   padding: 5px;
   -moz-appearance: toolbarbutton;