Bug 1230671 - add documentation to CustomizableUI for being careful about adding default panel items due to possible CART regressions. rs=jaws, DONTBUILD.
authorMike Conley <mconley@mozilla.com>
Fri, 05 Feb 2016 11:25:18 -0500
changeset 319550 73ebed82822cb54d3f85319b557a69be3483677f
parent 319549 b03138ad0c4a56cca94818982400790334a4ed86
child 319551 e5daa0514aea68fedd729cfe44dc02c3c2042e3b
push id5913
push userjlund@mozilla.com
push dateMon, 25 Apr 2016 16:57:49 +0000
treeherdermozilla-beta@dcaf0a6fa115 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws, DONTBUILD
bugs1230671
milestone47.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1230671 - add documentation to CustomizableUI for being careful about adding default panel items due to possible CART regressions. rs=jaws, DONTBUILD.
browser/components/customizableui/CustomizableUI.jsm
--- a/browser/components/customizableui/CustomizableUI.jsm
+++ b/browser/components/customizableui/CustomizableUI.jsm
@@ -175,16 +175,25 @@ var CustomizableUIInternal = {
     log.debug("Initializing");
 
     this.addListener(this);
     this._defineBuiltInWidgets();
     this.loadSavedState();
     this._introduceNewBuiltinWidgets();
     this._markObsoleteBuiltinButtonsSeen();
 
+    /**
+     * Please be advised that adding items to the panel by default could
+     * cause CART talos test regressions. This might happen when the
+     * number of items in the panel causes the area to become "scrollable"
+     * during the last phases of the transition. See bug 1230671 for an
+     * example of this. Be sure that what you're adding really needs to go
+     * into the panel by default, and if it does, consider swapping
+     * something out for it.
+     */
     let panelPlacements = [
       "edit-controls",
       "zoom-controls",
       "new-window-button",
       "privatebrowsing-button",
       "save-page-button",
       "print-button",
       "history-panelmenu",