Bug 1434913 - Make FetchEvent.clientId non-nullable r=mrbkap
authorPerry Jiang <pjiang@mozilla.com>
Thu, 16 Aug 2018 14:20:41 +0000
changeset 487002 73847b793895ce36f5918f687fd652f330ff5319
parent 487001 160ed81f18c44a9d22a34fec7fd9836c616b8581
child 487003 3d98e379dc389fce823507040d3ce2a77970fb35
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmrbkap
bugs1434913
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1434913 - Make FetchEvent.clientId non-nullable r=mrbkap Make FetchEvent.clientId non-nullable Differential Revision: https://phabricator.services.mozilla.com/D2789
dom/webidl/FetchEvent.webidl
testing/web-platform/meta/service-workers/service-worker/fetch-event.https.html.ini
--- a/dom/webidl/FetchEvent.webidl
+++ b/dom/webidl/FetchEvent.webidl
@@ -7,20 +7,20 @@
  * http://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html
  */
 
 [Constructor(DOMString type, FetchEventInit eventInitDict),
  Func="ServiceWorkerVisible",
  Exposed=(ServiceWorker)]
 interface FetchEvent : ExtendableEvent {
   [SameObject] readonly attribute Request request;
-  readonly attribute DOMString? clientId;
+  readonly attribute DOMString clientId;
   readonly attribute boolean isReload;
 
   [Throws]
   void respondWith(Promise<Response> r);
 };
 
 dictionary FetchEventInit : EventInit {
   required Request request;
-  DOMString? clientId = null;
+  DOMString clientId = "";
   boolean isReload = false;
 };
--- a/testing/web-platform/meta/service-workers/service-worker/fetch-event.https.html.ini
+++ b/testing/web-platform/meta/service-workers/service-worker/fetch-event.https.html.ini
@@ -1,15 +1,12 @@
 [fetch-event.https.html]
   [Service Worker responds to fetch event with the correct keepalive value]
     expected: FAIL
 
-  [Service Worker responds to fetch event with an existing client id]
-    expected: FAIL
-
   [Service Worker responds to fetch event with the correct isReloadNavigation value]
     expected: FAIL
 
   [FetchEvent#request.isReloadNavigation is true (location.reload())]
     expected: FAIL
 
   [FetchEvent#request.isReloadNavigation is true (history.go(0))]
     expected: FAIL