Bug 1298204 - Make sure the form autocomplete popup tree gets updated when invalidated. r=MattN
authorMike Conley <mconley@mozilla.com>
Tue, 30 Aug 2016 22:57:26 -0400
changeset 354825 73153f2fee67fb1b1f0a8974c6619892f4d4190b
parent 354824 6abd2090658b48dbd921827daddf2f953ada9de5
child 354826 6ae316bcf8ee0946504240ce10cae18a711f2556
push id6570
push userraliiev@mozilla.com
push dateMon, 14 Nov 2016 12:26:13 +0000
treeherdermozilla-beta@f455459b2ae5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersMattN
bugs1298204, 1294502
milestone51.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1298204 - Make sure the form autocomplete popup tree gets updated when invalidated. r=MattN Bug 1294502 recently refactored the form autocomplete code to combine the e10s and non-e10s mechanisms. The new combined mechanism works using something mostly similar to what we used for e10s, except that we forgot to re-set the nsITreeView when the autocomplete results are invalidated. MozReview-Commit-ID: 4veXklEgLGl
toolkit/components/satchel/AutoCompletePopup.jsm
--- a/toolkit/components/satchel/AutoCompletePopup.jsm
+++ b/toolkit/components/satchel/AutoCompletePopup.jsm
@@ -157,16 +157,19 @@ this.AutoCompletePopup = {
     if (!this.openedPopup) {
       return;
     }
 
     if (!results.length) {
       this.closePopup();
     } else {
       AutoCompleteTreeView.setResults(results);
+      // We need to re-set the view in order for the
+      // tree to know the view has changed.
+      this.openedPopup.view = AutoCompleteTreeView;
       this.openedPopup.invalidate();
     }
   },
 
   closePopup() {
     if (this.openedPopup) {
       this.openedPopup.closePopup();
     }