Bug 1136450 - WebIDE packaging check did not function correctly. r=ochameau, a=lsblakk
authorJ. Ryan Stinnett <jryans@gmail.com>
Wed, 25 Feb 2015 08:55:06 -0600
changeset 257445 72eb85afdde6e9d0382859727cd64b28beba26e3
parent 257444 8a0d1a42bb4c04d308a3c5bf73652e92041c1d6e
child 257446 d8d04e0bbaa64fa2dcb00c4c0255c28e18d555fe
push id4610
push userjlund@mozilla.com
push dateMon, 30 Mar 2015 18:32:55 +0000
treeherdermozilla-beta@4df54044d9ef [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersochameau, lsblakk
bugs1136450
milestone38.0a2
Bug 1136450 - WebIDE packaging check did not function correctly. r=ochameau, a=lsblakk
browser/devtools/webide/modules/build.js
--- a/browser/devtools/webide/modules/build.js
+++ b/browser/devtools/webide/modules/build.js
@@ -32,17 +32,17 @@ const ProjectBuilding = exports.ProjectB
 
   hasPrepackage: Task.async(function* (project) {
     let manifest = yield ProjectBuilding.fetchPackageManifest(project);
     return manifest && manifest.webide && "prepackage" in manifest.webide;
   }),
 
   // If the app depends on some build step, run it before pushing the app
   build: Task.async(function* ({ project, logger }) {
-    if (!this.hasPrepackage(project)) {
+    if (!(yield this.hasPrepackage(project))) {
       return;
     }
 
     let manifest = yield ProjectBuilding.fetchPackageManifest(project);
 
     logger("start");
     let packageDir;
     try {
@@ -163,9 +163,8 @@ const ProjectBuilding = exports.ProjectB
       let exists = yield OS.File.exists(packageDir);
       if (exists) {
         return packageDir;
       }
       throw new Error("Unable to resolve application package directory: '" + manifest.packageDir + "'");
     }
   }),
 };
-