Bug 1042642 - Remove eventSource from EnvironmentClient; r=jdescottes
authoryulia <ystartsev@mozilla.com>
Tue, 30 Apr 2019 14:57:10 +0000
changeset 530778 72e61b1971a31a562b9dde08c122c44992d70474
parent 530777 0e9ee7d2188b6c82549ce2b23e159b99f32ab452
child 530779 139a838ca42fb715041775925f0aa5a994700e74
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdescottes
bugs1042642
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1042642 - Remove eventSource from EnvironmentClient; r=jdescottes After reviewing how the EnvironmentClient is used, it looks like the use of eventSource might be some cruft from the past. Here is the try run: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=242251058&revision=df4bb52f188f79b8006e8c40401e5af2258493ce with the exception of whatever is going on Window 7 (which appeares also on central), it looks like things are working as expected. The environment client will eventually have the event emitter, once it is moved to being a front. adding @nchevobbe as a subscriber, as this touches a dependancy of the scratchpad. Differential Revision: https://phabricator.services.mozilla.com/D28962
devtools/shared/client/environment-client.js
--- a/devtools/shared/client/environment-client.js
+++ b/devtools/shared/client/environment-client.js
@@ -1,16 +1,15 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 "use strict";
 
 const {arg, DebuggerClient} = require("devtools/shared/client/debugger-client");
-const eventSource = require("devtools/shared/client/event-source");
 
 /**
  * Environment clients are used to manipulate the lexical environment actors.
  *
  * @param client DebuggerClient
  *        The debugger client parent.
  * @param form Object
  *        The form sent across the remote debugging protocol.
@@ -44,11 +43,9 @@ EnvironmentClient.prototype = {
    */
   assign: DebuggerClient.requester({
     type: "assign",
     name: arg(0),
     value: arg(1),
   }),
 };
 
-eventSource(EnvironmentClient.prototype);
-
 module.exports = EnvironmentClient;