bug 1394130 - point osx l10n at the repackage task to avoid re-signing widevine. r=callek
authorAki Sasaki <asasaki@mozilla.com>
Wed, 30 Aug 2017 09:50:07 -0700
changeset 428484 72aae1305b7fa075b615950cc7b81353868fe354
parent 428483 8ec11dc8ccc40432e13f80fbaa8a109cd2cbf202
child 428485 00f0c51097671dd0716e753fef2f55c256299539
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscallek
bugs1394130
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1394130 - point osx l10n at the repackage task to avoid re-signing widevine. r=callek The signing pool is a limited resource. We already have logic to avoid re-signing widevine if the .sig files are there, and we're taking advantage of that on linux and windows. OSX was the lone desktop os still pointing at the unsigned bits for l10n. We're pointing at repackage instead of signing because the l10n logic expects a dmg. MozReview-Commit-ID: FtWa4o5s7aJ
taskcluster/ci/nightly-l10n/kind.yml
taskcluster/taskgraph/transforms/l10n.py
--- a/taskcluster/ci/nightly-l10n/kind.yml
+++ b/taskcluster/ci/nightly-l10n/kind.yml
@@ -83,17 +83,17 @@ job-template:
             EN_US_PACKAGE_NAME: target.tar.bz2
             EN_US_BINARY_URL:
                task-reference: https://queue.taskcluster.net/v1/task/<signed-build>/artifacts/public/build
             MAR_TOOLS_URL:
                task-reference: https://queue.taskcluster.net/v1/task/<unsigned-build>/artifacts/public/build/host/bin
          macosx64-nightly:
             EN_US_PACKAGE_NAME: target.dmg
             EN_US_BINARY_URL:
-               task-reference: https://queue.taskcluster.net/v1/task/<unsigned-build>/artifacts/public/build
+               task-reference: https://queue.taskcluster.net/v1/task/<repackage>/artifacts/public/build
             MAR_TOOLS_URL:
                task-reference: https://queue.taskcluster.net/v1/task/<unsigned-build>/artifacts/public/build/host/bin
          win.*:
             EN_US_PACKAGE_NAME: target.zip
             EN_US_BINARY_URL:
                task-reference: https://queue.taskcluster.net/v1/task/<signed-build>/artifacts/public/build
             EN_US_INSTALLER_BINARY_URL:
                task-reference: https://queue.taskcluster.net/v1/task/<repackage-signed>/artifacts/public/build
--- a/taskcluster/taskgraph/transforms/l10n.py
+++ b/taskcluster/taskgraph/transforms/l10n.py
@@ -216,16 +216,20 @@ def setup_nightly_dependency(config, job
             continue  # do not add a dep unless we're a nightly
         job['dependencies'] = {'unsigned-build': job['dependent-task'].label}
         if job['attributes']['build_platform'].startswith('win') or \
                 job['attributes']['build_platform'].startswith('linux'):
             # Weave these in and just assume they will be there in the resulting graph
             job['dependencies'].update({
                 'signed-build': 'build-signing-{}'.format(job['name']),
             })
+        if job['attributes']['build_platform'].startswith('macosx'):
+            job['dependencies'].update({
+                'repackage': 'repackage-{}'.format(job['name'])
+            })
         if job['attributes']['build_platform'].startswith('win'):
             job['dependencies'].update({
                 'repackage-signed': 'repackage-signing-{}'.format(job['name'])
             })
         yield job
 
 
 @transforms.add