Bug 1115673 - naming style for enums in NFCTechType and NFCTagType. r=smaug, dimi
authorYoshi Huang <allstars.chh@mozilla.com>
Tue, 30 Dec 2014 19:33:52 +0800
changeset 247951 71305476947b395b7df4ff7d951ad4c0940623dd
parent 247950 c6251e0f5230a133cd15ffe24259c49f10df61af
child 247952 dc341b949c0bb7cd4d461204a8bf9d013dea8fd2
push id4489
push userraliiev@mozilla.com
push dateMon, 23 Feb 2015 15:17:55 +0000
treeherdermozilla-beta@fd7c3dc24146 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug, dimi
bugs1115673
milestone37.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1115673 - naming style for enums in NFCTechType and NFCTagType. r=smaug, dimi
dom/webidl/MozNFCTag.webidl
--- a/dom/webidl/MozNFCTag.webidl
+++ b/dom/webidl/MozNFCTag.webidl
@@ -3,38 +3,41 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  *
  * Part of this idl is from:
  * http://w3c.github.io/nfc/proposals/common/nfc.html#nfctag-interface
  *
  * Copyright © 2013 Deutsche Telekom, Inc.
  */
 
+/**
+ * The enumeration of NFC Tag technologies.
+ */
 enum NFCTechType {
-  "NFC_A",
-  "NFC_B",
-  "NFC_F",
-  "NFC_V",
-  "NFC_ISO_DEP",
-  "MIFARE_CLASSIC",
-  "MIFARE_ULTRALIGHT",
-  "NFC_BARCODE"
+  "NFC-A",  // NFCForum-TS-DigitalProtocol-1.1 NFC-A.
+  "NFC-B",  // NFCForum-TS-DigitalProtocol-1.1 NFC-B.
+  "NFC-F",  // NFCForum-TS-DigitalProtocol-1.1 NFC-F.
+  "NFC-V",  // ISO 15693.
+  "ISO-DEP",  // NFCForum-TS-DigitalProtocol-1.1 ISO-DEP.
+  "MIFARE-Classic",  // MIFARE Classic from NXP.
+  "MIFARE-Ultralight",  // MIFARE Ultralight from NXP.
+  "NFC-Barcode" // NFC Barcode from Kovio.
 };
 
 /**
  * The enumeration of the types of the tag, the type of a tag could be either
- * one of those types defined in NFC Forum (type1 ~ type 4), or it could be a
- * NXP-specific tag, like Mifare Classic.
+ * one of those types defined in NFC Forum Tag Types (Type1 ~ Type 4), or it
+ * could be a NXP-specific tag, like MIFARE Classic.
  */
 enum NFCTagType {
-  "type1",
-  "type2",
-  "type3",
-  "type4",
-  "mifare_classic"
+  "Type1",
+  "Type2",
+  "Type3",
+  "Type4",
+  "MIFARE-Classic"
 };
 
 [JSImplementation="@mozilla.org/nfc/tag;1", AvailableIn="PrivilegedApps"]
 interface MozNFCTag {
   /**
    * The supported technologies of this tag, null if unknown.
    */
   [Cached, Pure] readonly attribute sequence<NFCTechType>? techList;