Bug 1511618 - js/src/tests/lib/jittests.py check_output should detect rc 139 as a crash. r=jmaher, a=test-only
authorBob Clary <bclary@bclary.com>
Mon, 31 Dec 2018 10:14:25 -0800
changeset 506481 7103a3f5a88a2d8e835eb56e9e23ad6413a0d574
parent 506480 1c0492ce0d72be1edf7c6bf53a304edc8e63dd6f
child 506482 3b1807d65b232e7e491c3f7cb8889bfb8763d031
push id10425
push userryanvm@gmail.com
push dateWed, 02 Jan 2019 14:38:06 +0000
treeherdermozilla-beta@45373d310ef9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher, test-only
bugs1511618
milestone65.0
Bug 1511618 - js/src/tests/lib/jittests.py check_output should detect rc 139 as a crash. r=jmaher, a=test-only
js/src/tests/lib/jittests.py
--- a/js/src/tests/lib/jittests.py
+++ b/js/src/tests/lib/jittests.py
@@ -507,16 +507,21 @@ def check_output(out, err, rc, timed_out
             return True
 
         # When building with ASan enabled, ASan will convert the -11 returned
         # value to 1. As a work-around we look for the error output which
         # includes the crash reason.
         if rc == 1 and ("Hit MOZ_CRASH" in err or "Assertion failure:" in err):
             return True
 
+        # When running jittests on Android, SEGV results in a return code
+        # of 128+11=139.
+        if rc == 139:
+            return True
+
     if rc != test.expect_status:
         # Tests which expect a timeout check for exit code 6.
         # Sometimes 0 is returned on Windows for unknown reasons.
         # See bug 899697.
         if sys.platform in ['win32', 'cygwin'] and rc == 0:
             return True
 
         # Allow a non-zero exit code if we want to allow OOM, but only if we