Bug 1534858 - Include minidumpwriter.exe in windows artifacts; r=chmanchester
authorGeoff Brown <gbrown@mozilla.com>
Tue, 26 Mar 2019 21:51:51 +0000
changeset 525054 6ee134f8c056e78b1b24dce58b93fe437ce4ea30
parent 525053 01c30f5cc07e9b9289d7aeb174ca12b0bd2cee47
child 525055 912818869defa9374097c1d6aaa077a83d60df1d
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerschmanchester
bugs1534858
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1534858 - Include minidumpwriter.exe in windows artifacts; r=chmanchester Test automation code assumes crashinject.exe is available on Win32: https://searchfox.org/mozilla-central/rev/7abb9117c8500ed20833746c9f8e800fce3a4688/build/automation.py.in#356 and minidumpwriter.exe on Windows when there is a 32/64 bit mismatch between python and the application build: https://searchfox.org/mozilla-central/rev/7abb9117c8500ed20833746c9f8e800fce3a4688/testing/mozbase/mozcrash/mozcrash/mozcrash.py#428 so I think these should be available for Windows tests, and I suspect they have only been left out accidentally. I will file a new bug to get minidumpwriter working on aarch64. Differential Revision: https://phabricator.services.mozilla.com/D23895
python/mozbuild/mozbuild/artifacts.py
--- a/python/mozbuild/mozbuild/artifacts.py
+++ b/python/mozbuild/mozbuild/artifacts.py
@@ -501,16 +501,17 @@ class WinArtifactJob(ArtifactJob):
     test_artifact_patterns = {
         ('bin/BadCertServer.exe', ('bin', 'bin')),
         ('bin/GenerateOCSPResponse.exe', ('bin', 'bin')),
         ('bin/OCSPStaplingServer.exe', ('bin', 'bin')),
         ('bin/SymantecSanctionsServer.exe', ('bin', 'bin')),
         ('bin/certutil.exe', ('bin', 'bin')),
         ('bin/fileid.exe', ('bin', 'bin')),
         ('bin/geckodriver.exe', ('bin', 'bin')),
+        ('bin/minidumpwriter.exe', ('bin', 'bin')),
         ('bin/pk12util.exe', ('bin', 'bin')),
         ('bin/screenshot.exe', ('bin', 'bin')),
         ('bin/ssltunnel.exe', ('bin', 'bin')),
         ('bin/xpcshell.exe', ('bin', 'bin')),
         ('bin/plugins/gmp-*/*/*', ('bin/plugins', 'bin')),
         ('bin/plugins/*', ('bin/plugins', 'plugins')),
         ('bin/components/*', ('bin/components', 'bin/components')),
     }