Bug 1534283 - use default parameters for mach try fuzzy r=tomprince
authorDustin J. Mitchell <dustin@mozilla.com>
Thu, 14 Mar 2019 19:32:05 +0000
changeset 521975 6e05f81a2f8f
parent 521974 e44be7f40c6d
child 521976 7cf6462189e8
push id10870
push usernbeleuzu@mozilla.com
push dateFri, 15 Mar 2019 20:00:07 +0000
treeherdermozilla-beta@c594aee5b7a4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstomprince
bugs1534283
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1534283 - use default parameters for mach try fuzzy r=tomprince Differential Revision: https://phabricator.services.mozilla.com/D23225
taskcluster/taskgraph/parameters.py
tools/tryselect/cli.py
tools/tryselect/tasks.py
--- a/taskcluster/taskgraph/parameters.py
+++ b/taskcluster/taskgraph/parameters.py
@@ -41,17 +41,17 @@ def get_version(product_dir='browser'):
 
 def get_app_version(product_dir='browser'):
     app_version_path = os.path.join(GECKO, product_dir, 'config',
                                     'version.txt')
     return get_contents(app_version_path)
 
 
 # Please keep this list sorted and in sync with taskcluster/docs/parameters.rst
-# Parameters are of the form: {name: default}
+# Parameters are of the form: {name: default} or {name: lambda: default}
 PARAMETERS = {
     'app_version': get_app_version(),
     'base_repository': 'https://hg.mozilla.org/mozilla-unified',
     'build_date': lambda: int(time.time()),
     'build_number': 1,
     'do_not_optimize': [],
     'existing_tasks': {},
     'filters': ['target_tasks_method'],
--- a/tools/tryselect/cli.py
+++ b/tools/tryselect/cli.py
@@ -63,17 +63,17 @@ COMMON_ARGUMENT_GROUPS = {
          {'action': 'store_true',
           'default': False,
           'help': "Use the full set of tasks as input to fzf (instead of "
                   "target tasks).",
           }],
         [['-p', '--parameters'],
          {'default': None,
           'help': "Use the given parameters.yml to generate tasks, "
-                  "defaults to latest parameters.yml from mozilla-central",
+                  "defaults to a default set of parameters",
           }],
     ],
 }
 
 
 class BaseTryParser(ArgumentParser):
     name = 'try'
     common_groups = ['push', 'preset']
--- a/tools/tryselect/tasks.py
+++ b/tools/tryselect/tasks.py
@@ -50,18 +50,16 @@ def invalidate(cache, root):
     tmod = max(os.path.getmtime(os.path.join(tc_dir, p)) for p, _ in FileFinder(tc_dir))
     cmod = os.path.getmtime(cache)
 
     if tmod > cmod:
         os.remove(cache)
 
 
 def generate_tasks(params, full, root):
-    params = params or "project=mozilla-central"
-
     # Try to delete the old taskgraph cache directory.
     old_cache_dir = os.path.join(get_state_dir(), 'cache', 'taskgraph')
     if os.path.isdir(old_cache_dir):
         shutil.rmtree(old_cache_dir)
 
     root_hash = hashlib.sha256(os.path.abspath(root)).hexdigest()
     cache_dir = os.path.join(get_state_dir(), 'cache', root_hash, 'taskgraph')