Bug 835635: Cast ArrayLength() result to (signed) 'gint' type in #define for CUSTOM_VALUE_INDEX, since we compare it to gint values all over the place. r=karlt
authorDaniel Holbert <dholbert@cs.stanford.edu>
Mon, 28 Jan 2013 18:58:07 -0800
changeset 130015 6d633b6a8d432628b04bbd9f64833dac895d3c40
parent 130014 33ad7882738af41aeccd4d76fc1f66d5a1f38001
child 130016 19b9f064d8eb910c9d7a613bb01812dd0e4ad904
push id2323
push userbbajaj@mozilla.com
push dateMon, 01 Apr 2013 19:47:02 +0000
treeherdermozilla-beta@7712be144d91 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskarlt
bugs835635
milestone21.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 835635: Cast ArrayLength() result to (signed) 'gint' type in #define for CUSTOM_VALUE_INDEX, since we compare it to gint values all over the place. r=karlt
widget/gtk2/nsPrintDialogGTK.cpp
--- a/widget/gtk2/nsPrintDialogGTK.cpp
+++ b/widget/gtk2/nsPrintDialogGTK.cpp
@@ -31,17 +31,17 @@
 #include "nsIDocShell.h"
 #include "WidgetUtils.h"
 
 using namespace mozilla;
 using namespace mozilla::widget;
 
 static const char header_footer_tags[][4] =  {"", "&T", "&U", "&D", "&P", "&PT"};
 
-#define CUSTOM_VALUE_INDEX ArrayLength(header_footer_tags)
+#define CUSTOM_VALUE_INDEX gint(ArrayLength(header_footer_tags))
 
 static GtkWindow *
 get_gtk_window_for_nsiwidget(nsIWidget *widget)
 {
   return GTK_WINDOW(widget->GetNativeData(NS_NATIVE_SHELLWIDGET));
 }
 
 static void