Bug 975312 - [mozrunner] Runner.check_for_crashes() should support save_path and quiet parameters. r=ahal
authorHenrik Skupin <mail@hskupin.info>
Fri, 21 Feb 2014 16:00:13 +0100
changeset 187086 6ce5b0f27bd593b3c6789a0fc6bc58175ab99dbd
parent 187085 a00bd379adb22dfef967b064805646a127c07e78
child 187087 fb8597ff68eaa59c1f61542b0caebd871fafb220
push id3503
push userraliiev@mozilla.com
push dateMon, 28 Apr 2014 18:51:11 +0000
treeherdermozilla-beta@c95ac01e332e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersahal
bugs975312
milestone30.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 975312 - [mozrunner] Runner.check_for_crashes() should support save_path and quiet parameters. r=ahal
testing/mozbase/mozrunner/mozrunner/base.py
--- a/testing/mozbase/mozrunner/mozrunner/base.py
+++ b/testing/mozbase/mozrunner/mozrunner/base.py
@@ -149,31 +149,36 @@ class Runner(object):
 
         return self.returncode
 
     def reset(self):
         """Reset the runner to its default state"""
         if getattr(self, 'profile', False):
             self.profile.reset()
 
-    def check_for_crashes(self, dump_directory=None, test_name=None):
+    def check_for_crashes(self, dump_directory=None, dump_save_path=None,
+                          test_name=None, quiet=False):
         """Check for a possible crash and output stack trace
 
         :param dump_directory: Directory to search for minidump files
+        :param dump_save_path: Directory to save the minidump files to
         :param test_name: Name to use in the crash output
+        :param quiet: If `True` don't print the PROCESS-CRASH message to stdout
 
         """
         if not dump_directory:
             dump_directory = os.path.join(self.profile.profile, 'minidumps')
 
         crashed = False
         try:
             crashed = mozcrash.check_for_crashes(dump_directory,
                                                  self.symbols_path,
-                                                 test_name=test_name)
+                                                 dump_save_path=dump_save_path,
+                                                 test_name=test_name,
+                                                 quiet=quiet)
         except:
             traceback.print_exc()
 
         return crashed
 
     def cleanup(self):
         """Cleanup all runner state"""
         self.stop()