Bug 893973 - crash in -[ChildView keyDown:], log more debugging info to Breakpad's app notes, rev1. r=masayuki
authorSteven Michaud <smichaud@pobox.com>
Thu, 01 Aug 2013 20:35:34 -0500
changeset 153336 6ca804ec71363e2e0ff5fbc7d587157dc64b43a0
parent 153335 610d98fa31f846995ff8eb7dbe0d6768750236b8
child 153337 5603000cc1bbdf22a67bbb2a2cf879bc4221211c
push id2859
push userakeybl@mozilla.com
push dateMon, 16 Sep 2013 19:14:59 +0000
treeherdermozilla-beta@87d3c51cd2bf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmasayuki
bugs893973
milestone25.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 893973 - crash in -[ChildView keyDown:], log more debugging info to Breakpad's app notes, rev1. r=masayuki
widget/cocoa/nsChildView.mm
--- a/widget/cocoa/nsChildView.mm
+++ b/widget/cocoa/nsChildView.mm
@@ -5218,18 +5218,19 @@ static int32_t RoundUp(double aDouble)
 - (void)keyDown:(NSEvent*)theEvent
 {
   NS_OBJC_BEGIN_TRY_ABORT_BLOCK;
 
 #if !defined(RELEASE_BUILD) || defined(DEBUG)
   if (mGeckoChild && mTextInputHandler && mTextInputHandler->IsFocused()) {
 #ifdef MOZ_CRASHREPORTER
     NSWindow* window = [self window];
-    NSString* info = [NSString stringWithFormat:@"view [%@], window [%@], key event [%@], window is key %i, app is active %i",
-                      self, window, theEvent, [window isKeyWindow], [NSApp isActive]];
+    NSString* info = [NSString stringWithFormat:@"\nview [%@], window [%@], key event [%@], window is key %i, is fullscreen %i, app is active %i",
+                      self, window, theEvent, [window isKeyWindow], ([window styleMask] & (1 << 14)) != 0,
+                      [NSApp isActive]];
     nsAutoCString additionalInfo([info UTF8String]);
 #endif
     if (mIsPluginView) {
       if (TextInputHandler::IsSecureEventInputEnabled()) {
         #define CRASH_MESSAGE "While a plugin has focus, we must not be in secure mode"
 #ifdef MOZ_CRASHREPORTER
         CrashReporter::AppendAppNotesToCrashReport(NS_LITERAL_CSTRING("\nBug 893973: ") +
                                                    NS_LITERAL_CSTRING(CRASH_MESSAGE));