Bug 742167. Give extendedAttribute() a better name. r=khuey
authorBoris Zbarsky <bzbarsky@mit.edu>
Tue, 10 Apr 2012 12:40:12 -0400
changeset 94635 6c93d7eb039aea2723d1c03a14e5e81ab36e5979
parent 94634 b1bed3ae047663cf7431986276ebc2d46cde805a
child 94636 a021e58d714f331a6e678cbf2ea0cf42b05401b1
push id886
push userlsblakk@mozilla.com
push dateMon, 04 Jun 2012 19:57:52 +0000
treeherdermozilla-beta@bbd8d5efd6d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskhuey
bugs742167
milestone14.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 742167. Give extendedAttribute() a better name. r=khuey
dom/bindings/Codegen.py
dom/bindings/parser/WebIDL.py
--- a/dom/bindings/Codegen.py
+++ b/dom/bindings/Codegen.py
@@ -599,17 +599,17 @@ class CGClassHasInstanceHook(CGAbstractS
   nsISupports* native =
     nsContentUtils::XPConnect()->GetNativeOfWrapper(cx, instance);
   nsCOMPtr<%s> qiResult = do_QueryInterface(native);
   *bp = !!qiResult;
   return true;
 """ % (self.descriptor.name, self.descriptor.hasInstanceInterface)
 
 def isChromeOnly(m):
-    return m.extendedAttribute("ChromeOnly")
+    return m.getExtendedAttribute("ChromeOnly")
 
 class PropertyDefiner:
     """
     A common superclass for defining things on prototype objects.
 
     Subclasses should implement generateArray to generate the actual arrays of
     things we're defining.  They should also set self.chrome to the list of
     things exposed to chrome and self.regular to the list of things exposed to
--- a/dom/bindings/parser/WebIDL.py
+++ b/dom/bindings/parser/WebIDL.py
@@ -1335,17 +1335,17 @@ class IDLInterfaceMember(IDLObjectWithId
             attrlist = list(attr)
             identifier = attrlist.pop(0)
             self.handleExtendedAttribute(identifier, attrlist)
             self._extendedAttrDict[identifier] = attrlist if len(attrlist) else True
 
     def handleExtendedAttribute(self, name, list):
         pass
 
-    def extendedAttribute(self, name):
+    def getExtendedAttribute(self, name):
         return self._extendedAttrDict.get(name, None)
 
 class IDLConst(IDLInterfaceMember):
     def __init__(self, location, identifier, type, value):
         IDLInterfaceMember.__init__(self, location, identifier,
                                     IDLInterfaceMember.Tags.Const)
 
         assert isinstance(type, IDLType)