Bug 873010 - Artifacts around small overlay scrollbars in select boxes. r=mstange, a=bajaj
authorAndré Reinald <areinald@mozilla.com>
Tue, 21 May 2013 12:58:00 -0700
changeset 142835 6c02abf3f2f9119f60c3163d77906a84570f1044
parent 142834 f7b87ea49450c0700c1a0e9775e4594876d5361d
child 142836 a9028805825f22963f1f5f069335435d5ea0cd25
push id2579
push userakeybl@mozilla.com
push dateMon, 24 Jun 2013 18:52:47 +0000
treeherdermozilla-beta@b69b7de8a05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange, bajaj
bugs873010
milestone23.0a2
Bug 873010 - Artifacts around small overlay scrollbars in select boxes. r=mstange, a=bajaj
widget/cocoa/nsNativeThemeCocoa.mm
widget/tests/test_bug485118.xul
--- a/widget/cocoa/nsNativeThemeCocoa.mm
+++ b/widget/cocoa/nsNativeThemeCocoa.mm
@@ -2639,17 +2639,17 @@ nsNativeThemeCocoa::GetWidgetOverflow(ns
       return true;
     }
   }
 
   return false;
 }
 
 static const int32_t kRegularScrollbarThumbMinSize = 26;
-static const int32_t kSmallScrollbarThumbMinSize = 19;
+static const int32_t kSmallScrollbarThumbMinSize = 26;
 
 NS_IMETHODIMP
 nsNativeThemeCocoa::GetMinimumWidgetSize(nsRenderingContext* aContext,
                                          nsIFrame* aFrame,
                                          uint8_t aWidgetType,
                                          nsIntSize* aResult,
                                          bool* aIsOverridable)
 {
--- a/widget/tests/test_bug485118.xul
+++ b/widget/tests/test_bug485118.xul
@@ -53,17 +53,18 @@ https://bugzilla.mozilla.org/show_bug.cg
 SimpleTest.waitForExplicitFinish();
 
 function runTest() {
   ["horizontal", "vertical"].forEach(function (orient) {
     ["", "Small"].forEach(function (size) {
       var elem = document.getElementById(orient + size);
       var thumbRect = document.getAnonymousElementByAttribute(elem, 'sbattr', 'scrollbar-thumb').getBoundingClientRect();
       var sizeToCheck = orient == "horizontal" ? "width" : "height";
-      var expectedSize = size == "Small" ? 19 : 26;
+      // var expectedSize = size == "Small" ? 19 : 26;
+      var expectedSize = 26;
       is(thumbRect[sizeToCheck], expectedSize, size + " scrollbar has wrong minimum " + sizeToCheck);
     });
   });
   SimpleTest.finish();
 }
 window.addEventListener("load", runTest, false);
 
 ]]>