Bug 1545075 - FlexContainer unmount callback is not called. r=jdescottes
authorGabriel Luong <gabriel.luong@gmail.com>
Wed, 17 Apr 2019 13:07:17 +0000
changeset 528712 6bbcccdf5f6be3b4e377ef40b5d7e37e5b99bb01
parent 528711 1455fb3278d1320e43352ea847649a26b749e58e
child 528713 635a123b100e8dd96f07d2b93607e5d108a80957
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdescottes
bugs1545075
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1545075 - FlexContainer unmount callback is not called. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D27886
devtools/client/inspector/flexbox/components/FlexContainer.js
--- a/devtools/client/inspector/flexbox/components/FlexContainer.js
+++ b/devtools/client/inspector/flexbox/components/FlexContainer.js
@@ -53,17 +53,17 @@ class FlexContainer extends PureComponen
         this.props.onSetFlexboxOverlayColor(previousColor);
       },
       onShow: () => {
         previousColor = this.props.color;
       },
     });
   }
 
-  componentWillUnMount() {
+  componentWillUnmount() {
     const tooltip = this.props.getSwatchColorPickerTooltip();
     tooltip.removeSwatch(this.swatchEl.current);
   }
 
   setFlexboxColor() {
     const color = this.colorValueEl.current.textContent;
     this.props.onSetFlexboxOverlayColor(color);
   }