Bug 842780 - about:newaddon doesn't restrict size of the add-on's icon. r=Unfocused
authorSachin Hosmani <sachinhosmani2@gmail.com>
Tue, 23 Apr 2013 12:04:30 +0530
changeset 140752 6b6e79e65b37f8566fa3c3263cd64025121ee177
parent 140751 95067eec6bde8b9bda3c5ffee106d8d7d90e95d8
child 140753 26caa9ab5c35ad5c927dfa145a21ed7a22d10353
push id2579
push userakeybl@mozilla.com
push dateMon, 24 Jun 2013 18:52:47 +0000
treeherdermozilla-beta@b69b7de8a05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersUnfocused
bugs842780
milestone23.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 842780 - about:newaddon doesn't restrict size of the add-on's icon. r=Unfocused
toolkit/mozapps/extensions/content/newaddon.js
toolkit/themes/linux/mozapps/extensions/newaddon.css
toolkit/themes/osx/mozapps/extensions/newaddon.css
toolkit/themes/windows/mozapps/extensions/newaddon.css
--- a/toolkit/mozapps/extensions/content/newaddon.js
+++ b/toolkit/mozapps/extensions/content/newaddon.js
@@ -46,26 +46,26 @@ function initialize() {
         !(aAddon.permissions & AddonManager.PERM_CAN_ENABLE)) {
       window.close();
       return;
     }
 
     gAddon = aAddon;
 
     document.getElementById("addon-info").setAttribute("type", aAddon.type);
-    
+
     let icon = document.getElementById("icon");
     if (aAddon.icon64URL)
       icon.src = aAddon.icon64URL;
     else if (aAddon.iconURL)
       icon.src = aAddon.iconURL;
 
     let name = bundle.formatStringFromName("name", [aAddon.name, aAddon.version],
                                            2);
-    document.getElementById("name").value = name
+    document.getElementById("name").value = name;
 
     if (aAddon.creator) {
       let creator = bundle.formatStringFromName("author", [aAddon.creator], 1);
       document.getElementById("author").value = creator;
     } else {
       document.getElementById("author").hidden = true;
     }
 
--- a/toolkit/themes/linux/mozapps/extensions/newaddon.css
+++ b/toolkit/themes/linux/mozapps/extensions/newaddon.css
@@ -31,16 +31,18 @@
 
 #addon-info {
   -moz-box-align: start;
   margin: 25px 10px;
 }
 
 #icon {
   -moz-margin-end: 10px;
+  max-width: 64px;
+  max-height: 64px;
   list-style-image: url("chrome://mozapps/skin/extensions/extensionGeneric.png");
 }
 
 .addon-info[type="theme"] #icon {
   list-style-image: url("chrome://mozapps/skin/extensions/themeGeneric.png");
 }
 
 .addon-info[type="locale"] #icon {
--- a/toolkit/themes/osx/mozapps/extensions/newaddon.css
+++ b/toolkit/themes/osx/mozapps/extensions/newaddon.css
@@ -33,16 +33,18 @@
 
 #addon-info {
   -moz-box-align: start;
   margin: 25px 10px;
 }
 
 #icon {
   -moz-margin-end: 10px;
+  max-width: 64px;
+  max-height: 64px;
   list-style-image: url("chrome://mozapps/skin/extensions/extensionGeneric.png");
 }
 
 .addon-info[type="theme"] #icon {
   list-style-image: url("chrome://mozapps/skin/extensions/themeGeneric.png");
 }
 
 .addon-info[type="locale"] #icon {
--- a/toolkit/themes/windows/mozapps/extensions/newaddon.css
+++ b/toolkit/themes/windows/mozapps/extensions/newaddon.css
@@ -31,16 +31,18 @@
 
 #addon-info {
   -moz-box-align: start;
   margin: 25px 10px;
 }
 
 #icon {
   -moz-margin-end: 10px;
+  max-width: 64px;
+  max-height: 64px;
   list-style-image: url("chrome://mozapps/skin/extensions/extensionGeneric.png");
 }
 
 .addon-info[type="theme"] #icon {
   list-style-image: url("chrome://mozapps/skin/extensions/themeGeneric.png");
 }
 
 .addon-info[type="locale"] #icon {