Bug 1527548 [wpt PR 15345] - Picture-in-Picture: remove/rename some methods in player/video element., a=testonly
authorMounir Lamouri <mlamouri@chromium.org>
Tue, 05 Mar 2019 11:11:02 +0000
changeset 522131 6b5a45ed3837f982e02608ebe096cc3e25ab2957
parent 522130 5d939be0e4cd18c9422fdd7ebcd0db2cc835bbc2
child 522132 793206aecd5e7cdc78e5e0dd1ea097f81608f466
push id10871
push usercbrindusan@mozilla.com
push dateMon, 18 Mar 2019 15:49:32 +0000
treeherdermozilla-beta@018abdd16060 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1527548, 15345, 1379049, 919860, 930338, 1409544, 631517
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1527548 [wpt PR 15345] - Picture-in-Picture: remove/rename some methods in player/video element., a=testonly Automatic update from web-platform-tests Picture-in-Picture: remove/rename some methods in player/video element. Mostly follow-ups from https://chromium-review.googlesource.com/c/chromium/src/+/1379049 Some methods became pointless, some had their meaning significantly changed. This CL also changes the timing of requestPictureInPicture() and exitPictureInPicture() in order to be sync until the call to the service. Bug: 919860, 930338 Change-Id: I437a060c2dd92021d514c4d6e2ffeb9f4642525b Reviewed-on: https://chromium-review.googlesource.com/c/1409544 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#631517} -- wpt-commits: 23aa71fddb589531b2883be10fcff85d535d374a wpt-pr: 15345
testing/web-platform/tests/picture-in-picture/disable-picture-in-picture.html
--- a/testing/web-platform/tests/picture-in-picture/disable-picture-in-picture.html
+++ b/testing/web-platform/tests/picture-in-picture/disable-picture-in-picture.html
@@ -42,17 +42,19 @@ promise_test(async t => {
 }, 'Request Picture-in-Picture rejects if disablePictureInPicture becomes ' +
    'true before promise resolves.');
 
 promise_test(async t => {
   const video = await loadVideo();
   return requestPictureInPictureWithTrustedClick(video)
   .then(() => {
     video.disablePictureInPicture = true;
-    assert_equals(document.pictureInPictureElement, null);
+    video.addEventListener('leavepictureinpicture', t.step_func(() => {
+      assert_equals(document.pictureInPictureElement, null);
+    }));
   });
 }, 'pictureInPictureElement is unset if disablePictureInPicture becomes true');
 
 promise_test(async t => {
   const video = await loadVideo();
   return requestPictureInPictureWithTrustedClick(video)
   .then(() => {
     video.disablePictureInPicture = false;