Bug 1450921 [wpt PR 10278] - Don't enforce name rule for RTCDTMFToneChangeEvent, a=testonly
authorHarald Alvestrand <hta@chromium.org>
Mon, 09 Apr 2018 21:35:21 +0000
changeset 467255 6b04eaf54eecd8fcf3094b6bfaa71f83c558dfac
parent 467254 b5aef667988fab412673b56830f4af3c76809e4a
child 467256 df33b6b95b927efc35f4c2d1cd7e477971c69824
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1450921, 10278, 822799, 992038, 547742
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1450921 [wpt PR 10278] - Don't enforce name rule for RTCDTMFToneChangeEvent, a=testonly Automatic update from web-platform-testsDon't enforce name rule for RTCDTMFToneChangeEvent Since the constructor of RTCDTMFToneChangeEvent is exposed, creating such events with other names than "tonechange" is possible. No reason to discriminate against such. Also adds tests for constructor. Bug: chromium:822799 Change-Id: I4b36f3094acee200dd4200c4d24f6b46e10a06e6 Reviewed-on: https://chromium-review.googlesource.com/992038 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#547742} wpt-commits: 6e2b4a77cb3d321b5d8a91bdbe4bbf8a0d777781 wpt-pr: 10278 wpt-commits: 6e2b4a77cb3d321b5d8a91bdbe4bbf8a0d777781 wpt-pr: 10278
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/webrtc/RTCDTMFSender-ontonechange.https.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -604474,17 +604474,17 @@
    "79574cff7e0500cecaf7e3ae182e89d98f49ce72",
    "testharness"
   ],
   "webrtc/RTCDTMFSender-ontonechange-long.https.html": [
    "d89602fd655bf032cadfc538291ccea858eb2446",
    "testharness"
   ],
   "webrtc/RTCDTMFSender-ontonechange.https.html": [
-   "4f53cbc7fafeeed5202774b58d4bf721055b382e",
+   "ecc1e77f083cb91af78b1bcb7311fe4b5b96313e",
    "testharness"
   ],
   "webrtc/RTCDataChannel-bufferedAmount.html": [
    "49f27767835ae80163b2a2889e6d5e98def5e22a",
    "testharness"
   ],
   "webrtc/RTCDataChannel-id.html": [
    "28ce3983bf04db02c62ed29b332a4a4b612affd2",
--- a/testing/web-platform/tests/webrtc/RTCDTMFSender-ontonechange.https.html
+++ b/testing/web-platform/tests/webrtc/RTCDTMFSender-ontonechange.https.html
@@ -277,9 +277,20 @@
       }
     });
 
     dtmfSender.addEventListener('tonechange', onToneChange);
     dtmfSender.insertDTMF('ABCD', 100, 70);
 
   }, `Setting transceiver.currentDirection to recvonly in the middle of tonechange events should stop future tonechange events from firing`);
 
+  /* Section 7.3 - Tone change event */
+  test(t => {
+    let ev = new RTCDTMFToneChangeEvent('tonechange', {'tone': '1'});
+    assert_equals(ev.type, 'tonechange');
+    assert_equals(ev.tone, '1');
+  }, 'Tone change event constructor works');
+
+  test(t => {
+    let ev = new RTCDTMFToneChangeEvent('worngname', {});
+  }, 'Tone change event with unexpected name should not crash');
+
 </script>