Bug 1472684: Hide info bar and guides from highlighter. r=gl a=lizzard
authorDaisuke Akatsuka <dakatsuka@mozilla.com>
Wed, 04 Jul 2018 10:50:12 +0900
changeset 477848 6ab86ccd136dbaa90824c81ce76469ba83b80c71
parent 477847 5f79cf2a5110c661dd49bddf6dccdc9cccea9050
child 477849 79290fd284cfc2226df07b793287d9c2037f2f10
push id9445
push userarchaeopteryx@coole-files.de
push dateSat, 07 Jul 2018 21:43:02 +0000
treeherdermozilla-beta@0a939a1cd7f9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgl, lizzard
bugs1472684
milestone62.0
Bug 1472684: Hide info bar and guides from highlighter. r=gl a=lizzard MozReview-Commit-ID: AAchCYg0d61
devtools/client/inspector/animation/animation.js
devtools/client/inspector/animation/components/AnimationTarget.js
--- a/devtools/client/inspector/animation/animation.js
+++ b/devtools/client/inspector/animation/animation.js
@@ -512,17 +512,18 @@ class AnimationInspector {
    * If no node is provided, hide the box model highlighter.
    *
    * @param {NodeFront} nodeFront
    */
   async setHighlightedNode(nodeFront) {
     await this.inspector.highlighters.hideBoxModelHighlighter();
 
     if (nodeFront) {
-      await this.inspector.highlighters.showBoxModelHighlighter(nodeFront);
+      await this.inspector.highlighters.showBoxModelHighlighter(
+        nodeFront, { hideInfoBar: true, hideGuides: true });
     }
 
     this.inspector.store.dispatch(updateHighlightedNode(nodeFront));
   }
 
   /**
    * Returns simulatable animation by given parameters.
    * The returned animation is implementing Animation interface of Web Animation API.
--- a/devtools/client/inspector/animation/components/AnimationTarget.js
+++ b/devtools/client/inspector/animation/components/AnimationTarget.js
@@ -83,17 +83,18 @@ class AnimationTarget extends Component 
       await this.updateNodeFront(this.props.animation);
     }
   }
 
   async highlight() {
     await this.ensureNodeFront();
 
     if (this.state.nodeFront) {
-      this.props.onShowBoxModelHighlighterForNode(this.state.nodeFront);
+      this.props.onShowBoxModelHighlighterForNode(
+        this.state.nodeFront, { hideInfoBar: true, hideGuides: true });
     }
   }
 
   async select() {
     await this.ensureNodeFront();
 
     if (this.state.nodeFront) {
       this.props.setSelectedNode(this.state.nodeFront);