Bug 987867 - JB & KK crash in java.util.ConcurrentModificationException: at java.util.LinkedList.next(LinkedList.java). r=mfinkle,ckitching, a=lsblakk
authorRichard Newman <rnewman@mozilla.com>
Fri, 25 Apr 2014 12:52:52 -0700
changeset 192170 69fcc2d9c81b4e8a52adebaa6af3d4abc73f44f6
parent 192165 b527b5318905087c51a73bc20145dcc05551fd80
child 192171 a7ab7384526e30e79702dc50ffe6fee4ea9a93b7
push id3507
push userrnewman@mozilla.com
push dateTue, 29 Apr 2014 03:11:17 +0000
treeherdermozilla-beta@69fcc2d9c81b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle, ckitching, lsblakk
bugs987867
milestone30.0
Bug 987867 - JB & KK crash in java.util.ConcurrentModificationException: at java.util.LinkedList.next(LinkedList.java). r=mfinkle,ckitching, a=lsblakk
mobile/android/base/favicons/cache/FaviconCache.java
--- a/mobile/android/base/favicons/cache/FaviconCache.java
+++ b/mobile/android/base/favicons/cache/FaviconCache.java
@@ -412,17 +412,16 @@ public class FaviconCache {
             FaviconsForURL element = permanentBackingMap.get(key);
             if (element == null) {
                 element = backingMap.get(key);
             }
 
             if (element == null) {
                 Log.w(LOGTAG, "Cannot compute dominant color of non-cached favicon. Cache fullness " +
                               currentSize.get() + '/' + maxSizeBytes);
-                finishRead();
                 return 0xFFFFFF;
             }
 
             return element.ensureDominantColor();
         } finally {
             finishRead();
         }
     }