Bug 1287024 - Remove unused mHashStores variable in Classifier.cpp. r=francois
authordimi <dlee@mozilla.com>
Fri, 15 Jul 2016 12:16:26 +0800
changeset 346218 6951eb08d08305ba5ffc3b8d956d8689f7b97cc3
parent 346217 2f91720817ab2f49b2e61460d92a28220868d73e
child 346219 50ff01c81e0944458ff72b4e307cbe720c88c6b3
push id6389
push userraliiev@mozilla.com
push dateMon, 19 Sep 2016 13:38:22 +0000
treeherdermozilla-beta@01d67bfe6c81 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfrancois
bugs1287024
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1287024 - Remove unused mHashStores variable in Classifier.cpp. r=francois MozReview-Commit-ID: 2EIDaRHKW8Q
toolkit/components/url-classifier/Classifier.cpp
toolkit/components/url-classifier/Classifier.h
--- a/toolkit/components/url-classifier/Classifier.cpp
+++ b/toolkit/components/url-classifier/Classifier.cpp
@@ -367,20 +367,16 @@ Classifier::SetLastUpdateTime(const nsAC
   LOG(("Marking table %s as last updated on %u",
        PromiseFlatCString(aTable).get(), updateTime));
   mTableFreshness.Put(aTable, updateTime / PR_MSEC_PER_SEC);
 }
 
 void
 Classifier::DropStores()
 {
-  for (uint32_t i = 0; i < mHashStores.Length(); i++) {
-    delete mHashStores[i];
-  }
-  mHashStores.Clear();
   for (uint32_t i = 0; i < mLookupCaches.Length(); i++) {
     delete mLookupCaches[i];
   }
   mLookupCaches.Clear();
 }
 
 nsresult
 Classifier::RegenActiveTables()
--- a/toolkit/components/url-classifier/Classifier.h
+++ b/toolkit/components/url-classifier/Classifier.h
@@ -92,17 +92,16 @@ private:
   // Root dir of the Local profile.
   nsCOMPtr<nsIFile> mCacheDirectory;
   // Main directory where to store the databases.
   nsCOMPtr<nsIFile> mStoreDirectory;
   // Used for atomically updating the other dirs.
   nsCOMPtr<nsIFile> mBackupDirectory;
   nsCOMPtr<nsIFile> mToDeleteDirectory;
   nsCOMPtr<nsICryptoHash> mCryptoHash;
-  nsTArray<HashStore*> mHashStores;
   nsTArray<LookupCache*> mLookupCaches;
   nsTArray<nsCString> mActiveTablesCache;
   uint32_t mHashKey;
   // Stores the last time a given table was updated (seconds).
   nsDataHashtable<nsCStringHashKey, int64_t> mTableFreshness;
 };
 
 } // namespace safebrowsing