Backed out changeset 9a94bd3da98f (bug 1532692) for mochitest failures at test_cloneElementVisually_poster.html.
authorBrindusan Cristian <cbrindusan@mozilla.com>
Fri, 08 Mar 2019 06:57:25 +0200
changeset 520974 6943cbd4af0564fb1b33922bf90ba48370c0439a
parent 520973 904bfb7c423ff05ad8ca6036c6abf90c277bb609
child 520975 54ed5eac2abca2519704c74bc5c421b846031504
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1532692
milestone67.0a1
backs out9a94bd3da98faf9f0bc27699a49cafe4b9315709
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 9a94bd3da98f (bug 1532692) for mochitest failures at test_cloneElementVisually_poster.html.
dom/html/HTMLVideoElement.cpp
dom/media/test/mochitest.ini
dom/media/test/poster-test.jpg
dom/media/test/test_cloneElementVisually_poster.html
--- a/dom/html/HTMLVideoElement.cpp
+++ b/dom/html/HTMLVideoElement.cpp
@@ -456,23 +456,16 @@ void HTMLVideoElement::CloneElementVisua
     return;
   }
 
   // Do we already have a visual clone target? If so, shut it down.
   if (mVisualCloneTarget) {
     EndCloningVisually();
   }
 
-  // If there's a poster set on the target video, clear it, otherwise
-  // it'll display over top of the cloned frames.
-  aTargetVideo.UnsetHTMLAttr(nsGkAtoms::poster, rv);
-  if (rv.Failed()) {
-    return;
-  }
-
   if (!SetVisualCloneTarget(&aTargetVideo)) {
     rv.Throw(NS_ERROR_FAILURE);
     return;
   }
 
   if (!aTargetVideo.SetVisualCloneSource(this)) {
     mVisualCloneTarget = nullptr;
     rv.Throw(NS_ERROR_FAILURE);
--- a/dom/media/test/mochitest.ini
+++ b/dom/media/test/mochitest.ini
@@ -528,17 +528,16 @@ support-files =
   owl-funny-id3.mp3^headers^
   owl.mp3
   owl.mp3^headers^
   owl-short.mp3
   owl-short.mp3^headers^
   parser.vtt
   pixel_aspect_ratio.mp4
   play_promise.js
-  poster-test.jpg
   r11025_msadpcm_c1.wav
   r11025_msadpcm_c1.wav^headers^
   r11025_s16_c1.wav
   r11025_s16_c1.wav^headers^
   r11025_s16_c1_trailing.wav
   r11025_s16_c1_trailing.wav^headers^
   r11025_s16_c1-short.wav
   r11025_s16_c1-short.wav^headers^
@@ -1338,11 +1337,9 @@ tags = cloneelementvisually
 skip-if = toolkit == 'android' # Visually cloning is only supported on Desktop for now.
 tags = cloneelementvisually
 [test_cloneElementVisually_resource_change.html]
 skip-if = toolkit == 'android' # Visually cloning is only supported on Desktop for now.
 tags = cloneelementvisually
 [test_cloneElementVisually_no_suspend.html]
 skip-if = toolkit == 'android' # Visually cloning is only supported on Desktop for now.
 tags = cloneelementvisually
-[test_cloneElementVisually_poster.html]
-skip-if = toolkit == 'android' # Visually cloning is only supported on Desktop for now.
-tags = cloneelementvisually
+
deleted file mode 100644
index 595a5315f86655f08222ecb18c6dfe48fa36e727..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100644
--- a/dom/media/test/test_cloneElementVisually_poster.html
+++ /dev/null
@@ -1,50 +0,0 @@
-<!DOCTYPE HTML>
-<html>
-<head>
-  <meta charset="utf-8">
-  <title>Test cloneElementVisually</title>
-  <script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
-  <script type="application/javascript" src="https://example.com:443/tests/dom/media/test/cloneElementVisually_helpers.js"></script>
-  <script src="/tests/SimpleTest/AddTask.js"></script>
-  <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css">
-</head>
-<body>
-<div id="content">
-  <h1>Original</h1>
-  <video id="original"></video>
-  <h1>Clone</h1>
-</div>
-<div id="results">
-  <h1>Results</h1>
-  <canvas id="left"></canvas>
-  <canvas id="right"></canvas>
-</div>
-
-<script type="application/javascript">
-
-/**
- * Test that when we start cloning a paused video, the clone displays
- * the first paused frame.
- */
-add_task(async () => {
-  await setup();
-
-  let originalVideo = document.getElementById("original");
-  const POSTER_URL = "https://example.com:443/tests/dom/media/test/poster-test.jpg";
-  originalVideo.setAttribute("poster", POSTER_URL);
-
-  await withNewClone(originalVideo, async clone => {
-    SpecialPowers.wrap(originalVideo).cloneElementVisually(clone);
-    await originalVideo.play();
-    await waitForEventOnce(originalVideo, "timeupdate");
-    await originalVideo.pause();
-
-    ok(await assertVideosMatch(originalVideo, clone),
-       "Video with a poster should clone properly.");
-  });
-});
-
-</script>
-
-</body>
-</html>