Bug 1399214 Make WPT try to fix stacks even if a symbol dir is not explicitly passed. r=jgraham
authorBen Kelly <ben@wanderview.com>
Tue, 12 Sep 2017 12:02:09 -0700
changeset 429819 68fc77ea1ef10f5ae69dc67899566391be636ee3
parent 429818 ea320a011ac9d7775d84bf9675682470dc75266f
child 429820 46b8854f1f8e710947d857af39e7933e08c7f868
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjgraham
bugs1399214
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1399214 Make WPT try to fix stacks even if a symbol dir is not explicitly passed. r=jgraham
testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py
@@ -147,17 +147,17 @@ class FirefoxBrowser(Browser):
         self.debug_info = debug_info
         self.profile = None
         self.symbols_path = symbols_path
         self.stackwalk_binary = stackwalk_binary
         self.ca_certificate_path = ca_certificate_path
         self.certutil_binary = certutil_binary
         self.e10s = e10s
         self.binary_args = binary_args
-        if self.symbols_path and stackfix_dir:
+        if stackfix_dir:
             self.stack_fixer = get_stack_fixer_function(stackfix_dir,
                                                         self.symbols_path)
         else:
             self.stack_fixer = None
 
         if timeout_multiplier:
             self.init_timeout = self.init_timeout * timeout_multiplier