Bug 813357 - Actually hand off our copy of the notification request to IPDL. r=gwagner, a=blocking-basecamp
authorBlake Kaplan <mrbkap@gmail.com>
Tue, 20 Nov 2012 18:22:32 -0800
changeset 117032 68e13e0df526e94c4a301d2d1c5e76f2f7adada5
parent 117031 e9d7bccb9b58b6cfcc56f652046b2f0c9d5a2d95
child 117033 aa59c272a7daa4d72d2ce487815d5ad5ee0f492e
push id1721
push userryanvm@gmail.com
push dateWed, 21 Nov 2012 04:17:42 +0000
treeherdermozilla-beta@d44ff5554e98 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgwagner, blocking-basecamp
bugs813357
milestone18.0
Bug 813357 - Actually hand off our copy of the notification request to IPDL. r=gwagner, a=blocking-basecamp
dom/src/notification/nsDesktopNotification.cpp
--- a/dom/src/notification/nsDesktopNotification.cpp
+++ b/dom/src/notification/nsDesktopNotification.cpp
@@ -101,17 +101,17 @@ nsDOMDesktopNotification::nsDOMDesktopNo
     // because owner implements nsITabChild, we can assume that it is
     // the one and only TabChild for this docshell.
     TabChild* child = GetTabChildFrom(GetOwner()->GetDocShell());
 
     // Retain a reference so the object isn't deleted without IPDL's knowledge.
     // Corresponding release occurs in DeallocPContentPermissionRequest.
     nsRefPtr<nsDesktopNotificationRequest> copy = request;
 
-    child->SendPContentPermissionRequestConstructor(request,
+    child->SendPContentPermissionRequestConstructor(copy.forget().get(),
                                                     NS_LITERAL_CSTRING("desktop-notification"),
                                                     NS_LITERAL_CSTRING("unused"),
                                                     IPC::Principal(mPrincipal));
 
     request->Sendprompt();
     return;
   }