Bug 1475094: remove colors and styles from heartbeat r=Gijs
authorEthan Glasser-Camp <ethan@betacantrips.com>
Mon, 25 Feb 2019 10:31:45 +0000
changeset 518746 688888df68359f9f8a4c65721cd1c75fbd83f5f5
parent 518745 95e3e6f91e6ee333a36568041945a25251fa723d
child 518747 aebfdeb5bad6f213ab7f48ec0d1d7dcad6508b0b
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1475094
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1475094: remove colors and styles from heartbeat r=Gijs These hard-coded colors actually remove our ability to respond to the user's theme. Get rid of them. Differential Revision: https://phabricator.services.mozilla.com/D20676
toolkit/components/normandy/skin/shared/Heartbeat.css
--- a/toolkit/components/normandy/skin/shared/Heartbeat.css
+++ b/toolkit/components/normandy/skin/shared/Heartbeat.css
@@ -1,16 +1,15 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 /* Notification overrides for Heartbeat UI */
 
 notification.heartbeat {
-  background-color: #F1F1F1 !important;
   border-bottom: 1px solid #C1C1C1 !important;
   height: 40px;
 }
 
 @keyframes pulse-onshow {
   0% {
     opacity: 0;
     transform: scale(1);
@@ -44,20 +43,18 @@ notification.heartbeat {
   }
 
   100% {
     transform: scale(1);
   }
 }
 
 .messageText.heartbeat {
-  color: #333 !important;
   margin-inline-end: 12px !important; /* The !important is required to override OSX default style. */
   margin-inline-start: 0;
-  text-shadow: none;
 }
 
 .messageImage.heartbeat {
   height: 24px !important;
   margin-inline-end: 8px !important;
   margin-inline-start: 8px !important;
   width: 24px !important;
 }
@@ -73,29 +70,23 @@ notification.heartbeat {
   animation-duration: 1s;
   animation-iteration-count: 2;
   animation-name: pulse-twice;
   animation-timing-function: linear;
 }
 
 /* Learn More link styles */
 .heartbeat > hbox > .text-link {
-  color: #0095DD !important;
   margin-inline-start: 0 !important;
 }
 
 .heartbeat > hbox > .text-link:hover {
-  color: #008ACB !important;
   text-decoration: none !important;
 }
 
-.heartbeat > hbox > .text-link:hover:active {
-  color: #006B9D !important;
-}
-
 /* Heartbeat UI Rating Star Classes */
 #star-rating-container {
   display: -moz-box;
   margin-bottom: 4px;
 }
 
 #star-rating-container > #star5 {
   -moz-box-ordinal-group: 5;