Bug 1533391 - Lint Debugger on try. r=davidwalsh
authorJason Laster <jlaster@mozilla.com>
Mon, 11 Mar 2019 18:43:17 +0000
changeset 521415 68834c8b15bd65191b9956abb8a1bfdb53c2d802
parent 521414 daaee58201c2efc43f2e8d5c6e4c7ddafe8970be
child 521416 8fe54aa70e8f6d2e143b4cdcbdfa377a4fce14ea
push id10866
push usernerli@mozilla.com
push dateTue, 12 Mar 2019 18:59:09 +0000
treeherdermozilla-beta@445c24a51727 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdavidwalsh
bugs1533391
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1533391 - Lint Debugger on try. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D22503
devtools/client/debugger/new/src/components/SecondaryPanes/Scopes.css
devtools/client/debugger/new/src/utils/editor/index.js
taskcluster/ci/source-test/node.yml
--- a/devtools/client/debugger/new/src/components/SecondaryPanes/Scopes.css
+++ b/devtools/client/debugger/new/src/components/SecondaryPanes/Scopes.css
@@ -1,14 +1,12 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
-
-
 .scopes-content .toggle-map-scopes {
   border-bottom: 1px solid var(--theme-splitter-color);
   margin-bottom: 3px;
   margin-left: 10px;
   padding: 0.5em 0;
 }
 
 .scopes-content .toggle-map-scopes input {
--- a/devtools/client/debugger/new/src/utils/editor/index.js
+++ b/devtools/client/debugger/new/src/utils/editor/index.js
@@ -160,17 +160,17 @@ function isVisible(codeMirror: any, top:
   return inXView && inYView;
 }
 
 export function getLocationsInViewport({ codeMirror }: Object) {
   // Get scroll position
   if (!codeMirror) {
     return {
       start: { line: 0, column: 0 },
-      end: { line: 0, column: 0 },
+      end: { line: 0, column: 0 }
     };
   }
   const charWidth = codeMirror.defaultCharWidth();
   const scrollArea = codeMirror.getScrollInfo();
   const { scrollLeft } = codeMirror.doc;
   const rect = codeMirror.getWrapperElement().getBoundingClientRect();
   const topVisibleLine = codeMirror.lineAtHeight(rect.top, "window");
   const bottomVisibleLine = codeMirror.lineAtHeight(rect.bottom, "window");
--- a/taskcluster/ci/source-test/node.yml
+++ b/taskcluster/ci/source-test/node.yml
@@ -8,20 +8,23 @@ debugger-tests:
     worker-type: aws-provisioner-v1/gecko-t-linux-xlarge
     worker:
         docker-image: {in-tree: "lint"}
         max-run-time: 1800
     run:
         using: run-task
         cache-dotcache: true
         command: >
+            cd /builds/worker/checkouts/gecko/ &&
+            npm install &&
             cd /builds/worker/checkouts/gecko/devtools/client/debugger/new/ &&
             yarn &&
             yarn flow &&
-            yarn test
+            yarn test &&
+            yarn lint
     when:
         files-changed:
             - 'devtools/client/debugger/new/**'
 
 eslint-plugin-mozilla:
     description: eslint-plugin-mozilla integration tests
     platform: linux64/opt
     treeherder: