Backed out changeset b2f02ad2c82b (bug 1363361) for frequently failing browser_appmenu_reflows.js on OS X. r=backout a=backout
authorSebastian Hengst <archaeopteryx@coole-files.de>
Thu, 20 Jul 2017 13:23:53 +0200
changeset 418530 68046a58f82913eb7804e4796ec981f6f8ea490e
parent 418529 c37e118e823b15e9569acf3b51d15f584ab1e81d
child 418531 cf759b6fb0af73de5108ea664281fec8057463a7
child 418555 de22d4444e76e5b8cdb80e772776d283210eaaf2
child 418663 84f072290811909edb1d2f4b31c238b6643f4d0a
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout, backout
bugs1363361
milestone56.0a1
backs outb2f02ad2c82b2d5b0088aa20c7caaa3bd203ed53
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset b2f02ad2c82b (bug 1363361) for frequently failing browser_appmenu_reflows.js on OS X. r=backout a=backout MozReview-Commit-ID: 5wPiUAKmDhi
dom/base/nsDOMWindowUtils.cpp
dom/interfaces/base/nsIDOMWindowUtils.idl
--- a/dom/base/nsDOMWindowUtils.cpp
+++ b/dom/base/nsDOMWindowUtils.cpp
@@ -4437,36 +4437,16 @@ nsDOMWindowUtils::GetDirectionFromText(c
     case eDir_Auto:
       MOZ_ASSERT_UNREACHABLE("GetDirectionFromText should never return this value");
       return NS_ERROR_FAILURE;
   }
   return NS_OK;
 }
 
 NS_IMETHODIMP
-nsDOMWindowUtils::EnsureDirtyRootFrame()
-{
-  nsIDocument* doc = GetDocument();
-  nsIPresShell* presShell = doc ? doc->GetShell() : nullptr;
-
-  if (!presShell) {
-    return NS_ERROR_FAILURE;
-  }
-
-  nsIFrame* frame = presShell->GetRootFrame();
-  if (!frame) {
-    return NS_ERROR_FAILURE;
-  }
-
-  presShell->FrameNeedsReflow(frame, nsIPresShell::eStyleChange,
-                              NS_FRAME_IS_DIRTY);
-  return NS_OK;
-}
-
-NS_IMETHODIMP
 nsDOMWindowUtils::GetIsStyledByServo(bool* aStyledByServo)
 {
   nsIDocument* doc = GetDocument();
   *aStyledByServo = doc && doc->IsStyledByServo();
   return NS_OK;
 }
 
 NS_INTERFACE_MAP_BEGIN(nsTranslationNodeList)
--- a/dom/interfaces/base/nsIDOMWindowUtils.idl
+++ b/dom/interfaces/base/nsIDOMWindowUtils.idl
@@ -2019,24 +2019,16 @@ interface nsIDOMWindowUtils : nsISupport
    *
    * @param aString the string to retrieve the direction for.
    * @return one of DIRECTION_LTR, DIRECTION_RTL or DIRECTION_NOT_SET depending
    *         on the first-strong character found in the string.
    */
   long getDirectionFromText(in AString aString);
 
   /**
-   * Calls FrameNeedsReflow on that root frame so that a layout flush
-   * will be necessary.
-   *
-   * This should only be used for testing.
-   */
-  void ensureDirtyRootFrame();
-
-  /**
    * Whether the current document is styled by Servo's style engine.
    *
    * This calls nsIDocument::IsStyledByServo().
    */
   readonly attribute boolean isStyledByServo;
 
   // These consts are only for testing purposes.
   const long DEFAULT_MOUSE_POINTER_ID = 0;