Bug 1378965 - silently include codegen.pp for DOM bindings; r=chmanchester
authorNathan Froyd <froydnj@mozilla.com>
Tue, 25 Jul 2017 11:17:32 -0400
changeset 419589 67f6a4e27d5d8cb08f97950c305d1f85e3f585f7
parent 419588 a18e17f0c0b6d08a8817c3e00a5a9e87130c6cca
child 419590 0318e26f75c82bf5c0938e1b616f623e2f55a5f9
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerschmanchester
bugs1378965
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1378965 - silently include codegen.pp for DOM bindings; r=chmanchester codegen.pp isn't available immediately (there's a rule to generate it), and so make warns when it's initially not found. But since this is a depends file, like other dependency files generated by the build process, we should silently include it so make doesn't even warn about it.
dom/bindings/Makefile.in
--- a/dom/bindings/Makefile.in
+++ b/dom/bindings/Makefile.in
@@ -36,17 +36,17 @@ CSS2Properties.webidl: $(css2properties_
 # changes to .webidl or .py files should result in code generation being
 # performed. But we do pull in file-lists.jon to catch file additions.
 codegen_dependencies := \
   file-lists.json \
   $(nonstatic_webidl_files) \
   $(GLOBAL_DEPS) \
   $(NULL)
 
-include codegen.pp
+-include codegen.pp
 
 codegen.pp: $(codegen_dependencies)
 	$(call py_action,webidl,$(srcdir))
 	@$(TOUCH) $@
 
 .PHONY: compiletests
 compiletests:
 	$(call SUBMAKE,libs,test)