Bug 1532462 - Avoid permission error in Android cppunittests on some devices by creating destination directory; r=bc
authorGeoff Brown <gbrown@mozilla.com>
Tue, 05 Mar 2019 17:03:27 +0000
changeset 520302 664638fa249e1d9ba53fb82acd8c72e96affb234
parent 520301 f6d891b25f431a1189fbb6c1e4d066f8e7d6ba92
child 520303 19047d153c2f5ddf5184def2be0745d2f1d936a8
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbc
bugs1532462
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1532462 - Avoid permission error in Android cppunittests on some devices by creating destination directory; r=bc Differential Revision: https://phabricator.services.mozilla.com/D22034
testing/remotecppunittests.py
--- a/testing/remotecppunittests.py
+++ b/testing/remotecppunittests.py
@@ -37,16 +37,17 @@ class RemoteCPPUnitTests(cppunittests.CP
         self.remote_home_dir = posixpath.join(self.remote_test_root, "h")
         if options.setup:
             self.setup_bin(progs)
 
     def setup_bin(self, progs):
         self.device.rm(self.remote_test_root, force=True, recursive=True)
         self.device.mkdir(self.remote_home_dir, parents=True)
         self.device.mkdir(self.remote_tmp_dir)
+        self.device.mkdir(self.remote_bin_dir)
         self.push_libs()
         self.push_progs(progs)
         self.device.chmod(self.remote_bin_dir, recursive=True, root=True)
 
     def push_libs(self):
         if self.options.local_apk:
             with mozfile.TemporaryDirectory() as tmpdir:
                 apk_contents = ZipFile(self.options.local_apk)