Bug 1486413 - Revert 'xul|textbox[focused]' rule accidentally added in Bug 1486413. r=jaws
authorMatthew Noorenberghe <mozilla@noorenberghe.ca>
Mon, 27 Aug 2018 19:02:34 +0000
changeset 488649 6589349f130310ecaea7a085ac1457d357c7b395
parent 488648 64feadb5fc6d1ce823608cb966ce4d4a2c13d56d
child 488650 febddb5a4dc21c7b09b02efc39568a03588d893b
push id9734
push usershindli@mozilla.com
push dateThu, 30 Aug 2018 12:18:07 +0000
treeherdermozilla-beta@71c71ab3afae [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1486413
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1486413 - Revert 'xul|textbox[focused]' rule accidentally added in Bug 1486413. r=jaws It was accidentally copied from the previous ruleset for the -moz-ui-invalid rules but I meant to invesigate whether -moz-ui-invalid applied to <xul:textbox> before landing. Differential Revision: https://phabricator.services.mozilla.com/D4359
toolkit/themes/shared/in-content/common.inc.css
--- a/toolkit/themes/shared/in-content/common.inc.css
+++ b/toolkit/themes/shared/in-content/common.inc.css
@@ -501,22 +501,23 @@ html|textarea {
 html|input[type="email"]:focus,
 html|input[type="tel"]:focus,
 html|input[type="text"]:focus,
 html|textarea:focus,
 xul|textbox[focused] {
   border-color: var(--in-content-border-focus);
 }
 
-/* Don't show the field error outlines and focus borders at the same time */
+/* Don't show the field error outlines and focus borders at the same time.
+   This doesn't apply to XUL <textbox> since they don't expose validity
+   attributes */
 html|input[type="email"]:-moz-ui-invalid:focus,
 html|input[type="tel"]:-moz-ui-invalid:focus,
 html|input[type="text"]:-moz-ui-invalid:focus,
-html|textarea:-moz-ui-invalid:focus,
-xul|textbox[focused] {
+html|textarea:-moz-ui-invalid:focus {
   border-color: transparent;
 }
 
 html|input[type="email"]:disabled,
 html|input[type="tel"]:disabled,
 html|input[type="text"]:disabled,
 html|textarea:disabled,
 xul|textbox[disabled="true"] {