Bug 1084589 - Fix a Yosemite topcrasher. r=gijskruitbosch a=gavin
authorSteven Michaud <smichaud@pobox.com>
Fri, 17 Oct 2014 19:26:49 -0500
changeset 233356 65006dd2ec2bd1a39a134a626c509fc376111470
parent 233355 39f034a76a1d535e3fcc1c1d675dc4d2fd02f1b4
child 233357 503bb896411a89458d788279ed5d3abb856fe6cf
push id4187
push userbhearsum@mozilla.com
push dateFri, 28 Nov 2014 15:29:12 +0000
treeherdermozilla-beta@f23cc6a30c11 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgijskruitbosch, gavin
bugs1084589
milestone35.0a2
Bug 1084589 - Fix a Yosemite topcrasher. r=gijskruitbosch a=gavin
widget/cocoa/nsNativeThemeCocoa.mm
--- a/widget/cocoa/nsNativeThemeCocoa.mm
+++ b/widget/cocoa/nsNativeThemeCocoa.mm
@@ -869,17 +869,17 @@ GetAquaAppearance()
 
 @interface NSObject(NSAppearanceCoreUIRendering)
 - (void)_drawInRect:(CGRect)rect context:(CGContextRef)cgContext options:(id)options;
 @end
 
 static void
 RenderWithCoreUI(CGRect aRect, CGContextRef cgContext, NSDictionary* aOptions)
 {
-  static id appearance = GetAquaAppearance();
+  id appearance = GetAquaAppearance();
 
   if (aRect.size.width * aRect.size.height > BITMAP_MAX_AREA) {
     return;
   }
 
   if (appearance && [appearance respondsToSelector:@selector(_drawInRect:context:options:)]) {
     // Render through NSAppearance on Mac OS 10.10 and up. This will call
     // CUIDraw with a CoreUI renderer that will give us the correct 10.10