Bug 943728 - Apply forgotten review comment, and small fixup. r=me
authorMike Hommey <mh+mozilla@glandium.org>
Tue, 03 Dec 2013 06:43:18 +0900
changeset 173065 646b46467e86e2bb065495eadfa020eefe113a14
parent 173064 a8dd314fcb9b27440495979d31bf5fa8ab5b0fca
child 173066 612b104050ce2fe75aca45f1754a7740a6691ddb
push id3224
push userlsblakk@mozilla.com
push dateTue, 04 Feb 2014 01:06:49 +0000
treeherdermozilla-beta@60c04d0987f1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs943728
milestone28.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 943728 - Apply forgotten review comment, and small fixup. r=me
testing/testsuite-targets.mk
--- a/testing/testsuite-targets.mk
+++ b/testing/testsuite-targets.mk
@@ -72,25 +72,25 @@ RUN_MOCHITEST_ROBOCOP = \
     --console-level=INFO --log-file=./$@.log --file-level=INFO $(DM_FLAGS) --dm_trans=$(DM_TRANS) \
     --app=$(TEST_PACKAGE_NAME) --deviceIP=${TEST_DEVICE} --xre-path=${MOZ_HOST_BIN} \
     --httpd-path=. \
     $(SYMBOLS_PATH) $(TEST_PATH_ARG) $(EXTRA_TEST_ARGS)
 
 ifndef NO_FAIL_ON_TEST_ERRORS
 define check_test_error_internal
   @errors=`grep 'TEST-UNEXPECTED-' $@.log` ;\
-  if test '$$errors' ; then \
+  if test "$$errors" ; then \
 	  echo '$@ failed:'; \
-	  echo '$$errors'; \
-          $(if $(1),echo $(1)) \
+	  echo "$$errors"; \
+          $(if $(1),echo $(1)); \
 	  exit 1; \
   fi
 endef
 CHECK_TEST_ERROR = $(call check_test_error_internal)
-CHECK_TEST_ERROR_RERUN = $(call check_test_error_internal,'To rerun your failures please run 'make $@-rerun-failures'')
+CHECK_TEST_ERROR_RERUN = $(call check_test_error_internal,'To rerun your failures please run "make $@-rerun-failures"')
 endif
 
 mochitest-remote: DM_TRANS?=adb
 mochitest-remote:
 	@if [ '${MOZ_HOST_BIN}' = '' ]; then \
         echo 'environment variable MOZ_HOST_BIN must be set to a directory containing host xpcshell'; \
     elif [ ! -d ${MOZ_HOST_BIN} ]; then \
         echo 'MOZ_HOST_BIN does not specify a directory'; \