Missing "return true;" in jsapi-test is what was really causing it to fail on tinderboxes. Sorry for the mess. r=orange, shame=me.
authorJason Orendorff <jorendorff@mozilla.com>
Wed, 09 Jun 2010 14:18:34 -0500
changeset 47425 633d4ea174a8f63e7adcf3d092116261115199ab
parent 47424 7fe6d41ae56d7ffd69f08ad05b9b99ff3ebcdfb1
child 47426 0254bc47933b5d6ef5e022b3bd73be4f06fd22f5
push id1
push userroot
push dateTue, 26 Apr 2011 22:38:44 +0000
treeherdermozilla-beta@bfdb6e623a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersorange
milestone1.9.3a5pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Missing "return true;" in jsapi-test is what was really causing it to fail on tinderboxes. Sorry for the mess. r=orange, shame=me.
js/src/jsapi-tests/testContexts.cpp
--- a/js/src/jsapi-tests/testContexts.cpp
+++ b/js/src/jsapi-tests/testContexts.cpp
@@ -66,16 +66,17 @@ BEGIN_TEST(testContexts_bug561444)
 	    jsvalRoot v(cx);
 	    if (!JS_EvaluateScript(cx, d->obj, d->code, strlen(d->code), __FILE__, __LINE__, v.addr()))
 		return;
 	}
 	JS_DestroyContext(cx);
 	d->ok = true;
     }
 END_TEST(testContexts_bug561444)
+#endif
 
 BEGIN_TEST(testContexts_bug563735)
 {
     JSContext *cx2 = JS_NewContext(rt, 8192);
     CHECK(cx2);
 
     JS_TransferRequest(cx, cx2);
     jsval v = JSVAL_NULL;
@@ -106,11 +107,11 @@ BEGIN_TEST(testContexts_bug570764)
 	JS_DestroyContext(cx2);
 
 	// Create and destroy second context.
 	cx2 = JS_NewContext(rt2, 8192);
 	CHECK(cx2);
 	JS_DestroyContext(cx2);
     }
     JS_DestroyRuntime(rt2);
+    return true;
 }
 END_TEST(testContexts_bug570764)
-#endif