Backed out changeset 42f5c08a4d86 (bug 1399985) on request from miketaylr
authorSebastian Hengst <archaeopteryx@coole-files.de>
Sat, 21 Apr 2018 01:44:52 +0300
changeset 468345 6225ece1cd5c51074488ee4997dd57abaec7b2a0
parent 468344 b041e24789f9656580976e54470b433d781f9f87
child 468346 5d2486077e4b1c7fd0fb059d38cb1b0733b96845
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1399985
milestone61.0a1
backs out42f5c08a4d86967ccd3df66c3fc3c30cc52c6497
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 42f5c08a4d86 (bug 1399985) on request from miketaylr
browser/extensions/webcompat-reporter/content/WebCompatReporter.jsm
--- a/browser/extensions/webcompat-reporter/content/WebCompatReporter.jsm
+++ b/browser/extensions/webcompat-reporter/content/WebCompatReporter.jsm
@@ -11,27 +11,25 @@ ChromeUtils.import("resource://gre/modul
 ChromeUtils.defineModuleGetter(this, "PageActions",
   "resource:///modules/PageActions.jsm");
 
 XPCOMUtils.defineLazyGetter(this, "wcStrings", function() {
   return Services.strings.createBundle(
     "chrome://webcompat-reporter/locale/webcompat.properties");
 });
 
-// Gather values for interesting details we want to appear in reports.
-let details = {};
-XPCOMUtils.defineLazyPreferenceGetter(details, "gfx.webrender.all", "gfx.webrender.all", false);
-XPCOMUtils.defineLazyPreferenceGetter(details, "gfx.webrender.blob-images", "gfx.webrender.blob-images", 1);
-XPCOMUtils.defineLazyPreferenceGetter(details, "gfx.webrender.enabled", "gfx.webrender.enabled", false);
-XPCOMUtils.defineLazyPreferenceGetter(details, "image.mem.shared", "image.mem.shared", 2);
-details.buildID = Services.appinfo.appBuildID;
-details.channel = AppConstants.MOZ_UPDATE_CHANNEL;
+// Gather values for prefs we want to appear in reports.
+let prefs = {};
+XPCOMUtils.defineLazyPreferenceGetter(prefs, "gfx.webrender.all", "gfx.webrender.all", false);
+XPCOMUtils.defineLazyPreferenceGetter(prefs, "gfx.webrender.blob-images", "gfx.webrender.blob-images", true);
+XPCOMUtils.defineLazyPreferenceGetter(prefs, "gfx.webrender.enabled", "gfx.webrender.enabled", false);
+XPCOMUtils.defineLazyPreferenceGetter(prefs, "image.mem.shared", "image.mem.shared", true);
 
 if (AppConstants.platform == "linux") {
-  XPCOMUtils.defineLazyPreferenceGetter(details, "layers.acceleration.force-enabled", "layers.acceleration.force-enabled", false);
+  XPCOMUtils.defineLazyPreferenceGetter(prefs, "layers.acceleration.force-enabled", "layers.acceleration.force-enabled", false);
 }
 
 let WebCompatReporter = {
   get endpoint() {
     return Services.urlFormatter.formatURLPref(
       "extensions.webcompat-reporter.newIssueEndpoint");
   },
 
@@ -88,19 +86,19 @@ let WebCompatReporter = {
     const SCREENSHOT_MESSAGE = "WebCompat:SendScreenshot";
     const FRAMESCRIPT = "chrome://webcompat-reporter/content/wc-frame.js";
     let win = Services.wm.getMostRecentWindow("navigator:browser");
     const WEBCOMPAT_ORIGIN = new win.URL(WebCompatReporter.endpoint).origin;
 
     let params = new URLSearchParams();
     params.append("url", `${tabData.url}`);
     params.append("src", "desktop-reporter");
-    params.append("details", JSON.stringify(details));
+    params.append("details", JSON.stringify(prefs));
 
-    if (details["gfx.webrender.all"] || details["gfx.webrender.enabled"]) {
+    if (prefs["gfx.webrender.all"] || prefs["gfx.webrender.enabled"]) {
       params.append("label", "type-webrender-enabled");
     }
 
     let tab = gBrowser.loadOneTab(
       `${WebCompatReporter.endpoint}?${params}`,
       {inBackground: false, triggeringPrincipal: Services.scriptSecurityManager.getSystemPrincipal()});
 
     // If we successfully got a screenshot blob, add a listener to know when