Bug 1158545 - Remove nsFilePickerProxy::mParent in favor of nsBaseFilePicker::mParent; r=roc
authorEhsan Akhgari <ehsan@mozilla.com>
Sat, 25 Apr 2015 11:38:34 -0400
changeset 271055 62091556e23a553817040c6a73dde37b33ade22c
parent 271054 2137146549d64c0a4100253b4801df6cfbb4d9ea
child 271056 c74ca7a01b15315091ad478abdf48cc1aa49d8ce
push id4830
push userjlund@mozilla.com
push dateMon, 29 Jun 2015 20:18:48 +0000
treeherdermozilla-beta@4c2175bb0420 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersroc
bugs1158545
milestone40.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1158545 - Remove nsFilePickerProxy::mParent in favor of nsBaseFilePicker::mParent; r=roc There is no need to have two separate variables for the same thing in the same object.
widget/nsFilePickerProxy.h
--- a/widget/nsFilePickerProxy.h
+++ b/widget/nsFilePickerProxy.h
@@ -54,18 +54,16 @@ public:
     // PFilePickerChild
     virtual bool
     Recv__delete__(const MaybeInputFiles& aFiles, const int16_t& aResult) override;
 
 private:
     ~nsFilePickerProxy();
     void InitNative(nsIWidget*, const nsAString&) override;
 
-    // This is an innerWindow.
-    nsCOMPtr<nsPIDOMWindow> mParent;
     nsCOMArray<nsIDOMFile> mDomfiles;
     nsCOMPtr<nsIFilePickerShownCallback> mCallback;
 
     int16_t   mSelectedType;
     nsString  mFile;
     nsString  mDefault;
     nsString  mDefaultExtension;