Bug 701376 - AwesomeBarTabs cleanup [r=mfinkle]
authorBrian Nicholson <bnicholson@mozilla.com>
Wed, 07 Dec 2011 17:52:05 -0800
changeset 83862 616da0ea72731345d0d6ef865ead8f99587960d9
parent 83861 25bbec664cb01b2a8859a87dc5e005d5e091caad
child 83863 0d7b275a3d6e170d1d56cb87edaf8cc8f9b4bf87
push id519
push userakeybl@mozilla.com
push dateWed, 01 Feb 2012 00:38:35 +0000
treeherdermozilla-beta@788ea1ef610b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle
bugs701376
milestone11.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 701376 - AwesomeBarTabs cleanup [r=mfinkle]
mobile/android/base/AwesomeBar.java
mobile/android/base/AwesomeBarTabs.java
--- a/mobile/android/base/AwesomeBar.java
+++ b/mobile/android/base/AwesomeBar.java
@@ -75,17 +75,17 @@ public class AwesomeBar extends Activity
         super.onCreate(savedInstanceState);
 
         Log.d(LOGTAG, "creating awesomebar");
 
         setContentView(R.layout.awesomebar_search);
 
         mAwesomeTabs = (AwesomeBarTabs) findViewById(R.id.awesomebar_tabs);
         mAwesomeTabs.setOnUrlOpenListener(new AwesomeBarTabs.OnUrlOpenListener() {
-            public void onUrlOpen(AwesomeBarTabs tabs, String url) {
+            public void onUrlOpen(String url) {
                 openUrlAndFinish(url);
             }
         });
 
         mGoButton = (ImageButton) findViewById(R.id.awesomebar_button);
         mGoButton.setOnClickListener(new Button.OnClickListener() {
             public void onClick(View v) {
                 openUrlAndFinish(mText.getText().toString());
--- a/mobile/android/base/AwesomeBarTabs.java
+++ b/mobile/android/base/AwesomeBarTabs.java
@@ -89,17 +89,17 @@ public class AwesomeBarTabs extends TabH
     private SimpleCursorAdapter mBookmarksAdapter;
     private SimpleExpandableListAdapter mHistoryAdapter;
 
     // FIXME: This value should probably come from a
     // prefs key (just like XUL-based fennec)
     private static final int MAX_RESULTS = 100;
 
     public interface OnUrlOpenListener {
-        public abstract void onUrlOpen(AwesomeBarTabs tabs, String url);
+        public abstract void onUrlOpen(String url);
     }
 
     private class HistoryListAdapter extends SimpleExpandableListAdapter {
         public HistoryListAdapter(Context context, List<? extends Map<String, ?>> groupData,
                 int groupLayout, String[] groupFrom, int[] groupTo,
                 List<? extends List<? extends Map<String, ?>>> childData,
                 int childLayout, String[] childFrom, int[] childTo) {
 
@@ -577,25 +577,25 @@ public class AwesomeBarTabs extends TabH
     private void handleHistoryItemClick(int groupPosition, int childPosition) {
         @SuppressWarnings("unchecked")
         Map<String,Object> historyItem =
                 (Map<String,Object>) mHistoryAdapter.getChild(groupPosition, childPosition);
 
         String url = (String) historyItem.get(AwesomeBar.URL_KEY);
 
         if (mUrlOpenListener != null)
-            mUrlOpenListener.onUrlOpen(this, url);
+            mUrlOpenListener.onUrlOpen(url);
     }
 
     private void handleItemClick(ListView list, int position) {
         Cursor cursor = (Cursor) list.getItemAtPosition(position);
         String url = cursor.getString(cursor.getColumnIndexOrThrow(AwesomeBar.URL_KEY));
 
         if (mUrlOpenListener != null)
-            mUrlOpenListener.onUrlOpen(this, url);
+            mUrlOpenListener.onUrlOpen(url);
     }
 
     public void setOnUrlOpenListener(OnUrlOpenListener listener) {
         mUrlOpenListener = listener;
     }
 
     public void destroy() {
         Cursor allPagesCursor = mAllPagesAdapter.getCursor();