Bug 1460346 - Remove unnecessary locking on an atomic value. r=pehrsons
authorAlex Chronopoulos <achronop@gmail.com>
Fri, 25 May 2018 11:59:08 +0300
changeset 479728 6105079ea2acad19899d21dc4a1b586f4a0d6dd0
parent 479727 ae5aec80f42bfb1663436a6c40964e475f184c7d
child 479729 656a0868f578d3012165dacf2e4f89ac6be7002c
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspehrsons
bugs1460346
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1460346 - Remove unnecessary locking on an atomic value. r=pehrsons MozReview-Commit-ID: 5SPjgHkPwTT
dom/media/GraphDriver.cpp
--- a/dom/media/GraphDriver.cpp
+++ b/dom/media/GraphDriver.cpp
@@ -770,20 +770,17 @@ AudioCallbackDriver::StartStream()
 {
   MOZ_ASSERT(!IsStarted() && OnCubebOperationThread());
   mShouldFallbackIfError = true;
   if (cubeb_stream_start(mAudioStream) != CUBEB_OK) {
     NS_WARNING("Could not start cubeb stream for MSG.");
     return false;
   }
 
-  {
-    MonitorAutoLock mon(mGraphImpl->GetMonitor());
-    mStarted = true;
-  }
+  mStarted = true;
   return true;
 }
 
 void
 AudioCallbackDriver::Stop()
 {
   MOZ_ASSERT(OnCubebOperationThread());
   if (cubeb_stream_stop(mAudioStream) != CUBEB_OK) {