author | Noemi Erli <nerli@mozilla.com> |
Fri, 19 Oct 2018 03:50:32 +0300 | |
changeset 497845 | 5f7e9756a2efa098d8e0d0e3a4d4447da0d0f1fd |
parent 497844 | 357559d3ec0de83e5a8075e7aad65d6493691f6e |
child 497846 | 1f63ece13c07c287fad4f5684da002747705bdd1 |
push id | 10002 |
push user | archaeopteryx@coole-files.de |
push date | Fri, 19 Oct 2018 23:09:29 +0000 |
treeherder | mozilla-beta@01378c910610 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
bugs | 1497514 |
milestone | 64.0a1 |
backs out | 8b3b53341da242116ef6cba6a4d8439bad5b0fb2 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/browser/components/payments/res/containers/basic-card-form.js +++ b/browser/components/payments/res/containers/basic-card-form.js @@ -146,20 +146,16 @@ export default class BasicCardForm exten "basic-card-page": basicCardPage, } = state; if (this.id && page && page.id !== this.id) { log.debug(`BasicCardForm: no need to further render inactive page: ${page.id}`); return; } - if (!basicCardPage.selectedStateKey) { - throw new Error("A `selectedStateKey` is required"); - } - let editing = !!basicCardPage.guid; this.cancelButton.textContent = this.dataset.cancelButtonLabel; this.backButton.textContent = this.dataset.backButtonLabel; if (editing) { this.saveButton.textContent = this.dataset.updateButtonLabel; } else { this.saveButton.textContent = this.dataset.nextButtonLabel; }
--- a/browser/components/payments/res/mixins/PaymentStateSubscriberMixin.js +++ b/browser/components/payments/res/mixins/PaymentStateSubscriberMixin.js @@ -12,17 +12,17 @@ import PaymentsStore from "../PaymentsSt * State of the payment request dialog. */ export let requestStore = new PaymentsStore({ changesPrevented: false, orderDetailsShowing: false, "basic-card-page": { guid: null, // preserveFieldValues: true, - selectedStateKey: "selectedPaymentCard", + selectedStateKey: null, }, "address-page": { guid: null, selectedStateKey: null, title: "", }, "payment-summary": { },
--- a/browser/components/payments/res/paymentRequest.js +++ b/browser/components/payments/res/paymentRequest.js @@ -162,19 +162,16 @@ var paymentRequest = { title: paymentDialog.dataset.billingAddressTitleAdd, }); } } else if (!hasSavedCards) { state.page = { id: "basic-card-page", onboardingWizard: true, }; - state["basic-card-page"] = { - selectedStateKey: "selectedPaymentCard", - }; } paymentDialog.setStateFromParent(state); }, openPreferences() { this.sendMessageToChrome("openPreferences"); },
--- a/browser/components/payments/test/browser/browser.ini +++ b/browser/components/payments/test/browser/browser.ini @@ -9,19 +9,19 @@ support-files = [browser_address_edit.js] skip-if = verify && debug && os == 'mac' [browser_card_edit.js] skip-if = os == 'linux' && debug # bug 1465673 [browser_change_shipping.js] [browser_dropdowns.js] [browser_host_name.js] -[browser_onboarding_wizard.js] [browser_openPreferences.js] [browser_payment_completion.js] +[browser_payments_onboarding_wizard.js] [browser_profile_storage.js] [browser_request_serialization.js] [browser_request_shipping.js] [browser_retry.js] [browser_shippingaddresschange_error.js] [browser_show_dialog.js] skip-if = os == 'win' && debug # bug 1418385 [browser_total.js]