Bug 1385407 - Add an extra selector for the urlbar-icon within the star-button-box now that the urlbar-icon for the bookmark star isn't a direct child of urlbar-icons. r=Gijs
☠☠ backed out by 9de78eb067cf ☠ ☠
authorJared Wein <jwein@mozilla.com>
Mon, 31 Jul 2017 11:39:05 -0400
changeset 420713 5f2af8ad61397dfaa61ede3cc1334d85f9be057d
parent 420712 0e724df2d505714cb63f3bd32e3b29f95f9c546e
child 420714 8536b787a5c7be6a453133e95a3de8e1bb86f6b9
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1385407, 1352063
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1385407 - Add an extra selector for the urlbar-icon within the star-button-box now that the urlbar-icon for the bookmark star isn't a direct child of urlbar-icons. r=Gijs This change in markup was necessary to implement bug 1352063. I have audited all other CSS to make sure other selectors looking for this icon still apply. This was the only one found that needed to be updated. MozReview-Commit-ID: 6O1iUUjJ0dh
browser/base/content/browser.css
--- a/browser/base/content/browser.css
+++ b/browser/base/content/browser.css
@@ -686,16 +686,17 @@ html|input.urlbar-input[textoverflow]:no
 }
 
 #DateTimePickerPanel[active="true"] {
   -moz-binding: url("chrome://global/content/bindings/datetimepopup.xml#datetime-popup");
 }
 
 #urlbar[pageproxystate="invalid"] > #urlbar-icons > .urlbar-icon,
 %ifdef MOZ_PHOTON_THEME
+#urlbar[pageproxystate="invalid"] > #urlbar-icons > #star-button-box > .urlbar-icon,
 .urlbar-go-button[pageproxystate="valid"],
 .urlbar-go-button:not([parentfocused="true"]),
 %else
 #urlbar[pageproxystate="invalid"][focused="true"] > #urlbar-go-button ~ toolbarbutton,
 #urlbar[pageproxystate="valid"] > #urlbar-go-button,
 #urlbar:not([focused="true"]) > #urlbar-go-button,
 %endif
 #urlbar[pageproxystate="invalid"] > #identity-box > #blocked-permissions-container,