Bug 987867 - JB & KK crash in java.util.ConcurrentModificationException: at java.util.LinkedList.next(LinkedList.java). r=mfinkle,ckitching, a=lsblakk
authorRichard Newman <rnewman@mozilla.com>
Fri, 25 Apr 2014 12:52:52 -0700
changeset 258649 5f238cb34fe7
parent 258648 fad6e80495ba
child 258650 bebd4af02d88
push id4700
push userryanvm@gmail.com
push date2015-04-21 23:53 +0000
Treeherderresults
reviewersmfinkle, ckitching, lsblakk
bugs987867
milestone29.0
Bug 987867 - JB & KK crash in java.util.ConcurrentModificationException: at java.util.LinkedList.next(LinkedList.java). r=mfinkle,ckitching, a=lsblakk
mobile/android/base/favicons/cache/FaviconCache.java
--- a/mobile/android/base/favicons/cache/FaviconCache.java
+++ b/mobile/android/base/favicons/cache/FaviconCache.java
@@ -412,17 +412,16 @@ public class FaviconCache {
             FaviconsForURL element = mPermanentBackingMap.get(key);
             if (element == null) {
                 element = mBackingMap.get(key);
             }
 
             if (element == null) {
                 Log.w(LOGTAG, "Cannot compute dominant color of non-cached favicon. Cache fullness " +
                               mCurrentSize.get() + '/' + mMaxSizeBytes);
-                finishRead();
                 return 0xFFFFFF;
             }
 
             return element.ensureDominantColor();
         } finally {
             finishRead();
         }
     }