Bug 1192309 - hgtool.py should set empty strings for Windows instead of None. r=jlund
authorArmen Zambrano Gasparnian <armenzg@mozilla.com>
Thu, 03 Sep 2015 14:14:21 -0400
changeset 294043 5eeb7f51f5bf61486395e05ee650d615d912b5ce
parent 294042 69b07795c5fa8718d7119eb7c0319318edf66d7f
child 294044 ef749ba572a4f01d4e4df36cc783a9a29033faeb
push id5245
push userraliiev@mozilla.com
push dateThu, 29 Oct 2015 11:30:51 +0000
treeherdermozilla-beta@dac831dc1bd0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjlund
bugs1192309
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1192309 - hgtool.py should set empty strings for Windows instead of None. r=jlund
testing/mozharness/mozharness/base/vcs/hgtool.py
--- a/testing/mozharness/mozharness/base/vcs/hgtool.py
+++ b/testing/mozharness/mozharness/base/vcs/hgtool.py
@@ -74,20 +74,20 @@ class HgtoolVCS(ScriptMixin, LogMixin, T
         env = {'PATH': os.environ.get('PATH')}
         if c.get('env'):
             env.update(c['env'])
         if share_base is not None:
             env['HG_SHARE_BASE_DIR'] = share_base
         if self._is_windows():
             # SYSTEMROOT is needed for 'import random'
             if 'SYSTEMROOT' not in env:
-                env['SYSTEMROOT'] = os.environ.get('SYSTEMROOT')
+                env['SYSTEMROOT'] = os.environ.get('SYSTEMROOT', '')
             # HOME is needed for the 'hg help share' check
             if 'HOME' not in env:
-                env['HOME'] = os.environ.get('HOME')
+                env['HOME'] = os.environ.get('HOME', '')
 
         cmd = self.hgtool[:]
 
         if clone_by_rev:
             cmd.append('--clone-by-revision')
         if branch:
             cmd.extend(['-b', branch])
         if revision: