Bug 1398656 - Always build the form autofill system add-on but disable it by default on release. r=lchang
authorMatthew Noorenberghe <mozilla@noorenberghe.ca>
Wed, 13 Sep 2017 17:29:49 -0700
changeset 430355 5e5eab26b9dec16c05f70c351d78863f8cb23900
parent 430347 1b5b6e3c41fc68b8f1efde169bd7962ba86b0a5b
child 430356 ff89cb83be0a2a1ba74099c839d4f796981dda67
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslchang
bugs1398656
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1398656 - Always build the form autofill system add-on but disable it by default on release. r=lchang The pref will gradually be flipped via Shield to "detect" on release. MozReview-Commit-ID: LaiEub8v05t
browser/app/profile/firefox.js
browser/extensions/moz.build
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -1687,20 +1687,23 @@ pref("browser.crashReports.unsubmittedCh
 // chancesUntilSuppress is how many times we'll show the unsubmitted
 // crash report notification across different days and shutdown
 // without a user choice before we suppress the notification for
 // some number of days.
 pref("browser.crashReports.unsubmittedCheck.chancesUntilSuppress", 4);
 pref("browser.crashReports.unsubmittedCheck.autoSubmit", false);
 
 // Preferences for the form autofill system extension
-// The value of "extensions.formautofill.available" can be "on", "off" and "detect".
-// The "detect" means it's enabled if conditions defined in the extension are met.
+// The truthy values of "extensions.formautofill.available" are "on" and "detect",
+// any other value means autofill isn't available.
+// "detect" means it's enabled if conditions defined in the extension are met.
 #ifdef NIGHTLY_BUILD
 pref("extensions.formautofill.available", "on");
+#elif MOZ_UPDATE_CHANNEL == release
+pref("extensions.formautofill.available", "staged-rollout");
 #else
 pref("extensions.formautofill.available", "detect");
 #endif
 pref("extensions.formautofill.addresses.enabled", true);
 pref("extensions.formautofill.creditCards.enabled", true);
 pref("extensions.formautofill.firstTimeUse", true);
 pref("extensions.formautofill.heuristics.enabled", true);
 pref("extensions.formautofill.loglevel", "Warn");
--- a/browser/extensions/moz.build
+++ b/browser/extensions/moz.build
@@ -5,37 +5,32 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 DIRS += [
     'activity-stream',
     'aushelper',
     'clicktoplay-rollout',
     'e10srollout',
     'followonsearch',
+    'formautofill',
     'onboarding',
     'pdfjs',
     'pocket',
     'screenshots',
     'shield-recipe-client',
     'webcompat',
 ]
 
 # Only include the following system add-ons if building Aurora or Nightly
 if not CONFIG['RELEASE_OR_BETA']:
     DIRS += [
         'flyweb',
         'presentation',
     ]
 
-# formautofill will be rolled out via balrog in release
-if CONFIG['MOZ_UPDATE_CHANNEL'] != 'release':
-    DIRS += [
-        'formautofill',
-    ]
-
 # Only include the following system add-ons if building DevEdition or Nightly
 if CONFIG['MOZ_DEV_EDITION'] or CONFIG['NIGHTLY_BUILD']:
     DIRS += [
         'webcompat-reporter',
     ]
 
 # Only include mortar system add-ons if we locally enable it
 if CONFIG['MOZ_MORTAR']: