Bug 1183196: [MSE] P3. Slightly increase debugging information. r=kentuckyfriedtakahe
authorJean-Yves Avenard <jyavenard@mozilla.com>
Wed, 29 Jul 2015 23:44:58 +1000
changeset 287121 5e130ad70aa766767fd7a2e89e1072f72f592d8b
parent 287120 e22318ab0a269c04d493b8927d20b6e6a69165ca
child 287122 59e6b29d756a9801cc6f689da2a183035b4fe1e7
push id5067
push userraliiev@mozilla.com
push dateMon, 21 Sep 2015 14:04:52 +0000
treeherdermozilla-beta@14221ffe5b2f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskentuckyfriedtakahe
bugs1183196
milestone42.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1183196: [MSE] P3. Slightly increase debugging information. r=kentuckyfriedtakahe Print the atom's offset, makes it easier to verify that byte ranges are properly calculated.
dom/media/mediasource/ContainerParser.cpp
--- a/dom/media/mediasource/ContainerParser.cpp
+++ b/dom/media/mediasource/ContainerParser.cpp
@@ -311,18 +311,19 @@ private:
       mp4_demuxer::ByteReader reader(aData);
       mp4_demuxer::AtomType initAtom("ftyp");
       mp4_demuxer::AtomType mediaAtom("moof");
 
       while (reader.Remaining() >= 8) {
         uint64_t size = reader.ReadU32();
         const uint8_t* typec = reader.Peek(4);
         uint32_t type = reader.ReadU32();
-        MSE_DEBUGV(AtomParser ,"Checking atom:'%c%c%c%c'",
-                   typec[0], typec[1], typec[2], typec[3]);
+        MSE_DEBUGV(AtomParser ,"Checking atom:'%c%c%c%c' @ %u",
+                   typec[0], typec[1], typec[2], typec[3],
+                   (uint32_t)reader.Offset() - 8);
         if (mInitOffset.isNothing() &&
             mp4_demuxer::AtomType(type) == initAtom) {
           mInitOffset = Some(reader.Offset());
         }
         if (mMediaOffset.isNothing() &&
             mp4_demuxer::AtomType(type) == mediaAtom) {
           mMediaOffset = Some(reader.Offset());
         }