Bug 1364023 - Remove LOCALE_SNAME define for ICU build. r=glandium
authorMakoto Kato <m_kato@ga2.so-net.ne.jp>
Mon, 05 Jun 2017 14:13:16 +0900
changeset 410429 5d990834b3e42f6900564f17a6e5f8aa1cd8eedc
parent 410428 c3bf2490530f5ac768040043b8d0dd55ce6c5a03
child 410430 4e0dc2b1aebdb1f9bf160117d8f714ddcf7d0079
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1364023
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1364023 - Remove LOCALE_SNAME define for ICU build. r=glandium Since we set WINVER=601 after dropping Windows XP support, it is unnecessary to define LOCALE_SNAME. So, we should remove it to remove compiler warning. MozReview-Commit-ID: EawbHAznXNA
config/external/icu/common/moz.build
--- a/config/external/icu/common/moz.build
+++ b/config/external/icu/common/moz.build
@@ -3,19 +3,16 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 Library('icuuc')
 FINAL_LIBRARY = 'icu'
 
 DEFINES['U_COMMON_IMPLEMENTATION'] = True
-# This normally gets defined in the SDK but our WINVER is too low.
-#FIXME: should probably stop including mozilla-config.h
-DEFINES['LOCALE_SNAME'] = 0x5c
 
 LOCAL_INCLUDES += ['/intl/icu/source/i18n']
 
 if CONFIG['GNU_CXX']:
     CXXFLAGS += [
         '-Wno-deprecated-declarations',
         '-Wno-type-limits',
         '-Wno-unused-but-set-variable',